Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add use case to get team url - cherypick (WPB-14872) #3167

Closed
wants to merge 6 commits into from

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 11, 2024

TaskWPB-14872 [Android] Wrong URL when opening team management after migration from button


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of #3157

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Garzas and others added 3 commits December 10, 2024 10:34
* feat: user folders

* detekt fix

* removed duplicated sq query

* fix: favorite folder error handling, non paginatated conversations from folder

* tests fix
* feat: add usecase to get team url

* feat:detekt

* feat: detekt

* feat: detekt
* feat: add usecase to get team url

* feat:detekt

* feat: detekt

* feat: detekt

(cherry picked from commit abcd037)
@ohassine ohassine changed the base branch from develop to release/candidate December 11, 2024 13:27
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 11, 2024
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 10.14493% with 62 lines in your changes missing coverage. Please review.

Project coverage is 54.09%. Comparing base (1fd8732) to head (51f292c).

Files with missing lines Patch % Lines
...rveConversationListDetailsWithEventsUseCaseImpl.kt 0.00% 13 Missing ⚠️
...lium/logic/data/conversation/ConversationFilter.kt 0.00% 11 Missing ⚠️
...o/conversation/folder/ConversationFolderDAOImpl.kt 9.09% 10 Missing ⚠️
...lium/logic/data/conversation/ConversationMapper.kt 0.00% 8 Missing and 1 partial ⚠️
...e/conversation/folder/ObserveUserFoldersUseCase.kt 0.00% 8 Missing ⚠️
...nversation/folders/ConversationFolderRepository.kt 0.00% 4 Missing and 1 partial ⚠️
...lium/logic/data/conversation/ConversationFolder.kt 0.00% 4 Missing ⚠️
.../logic/data/conversation/ConversationRepository.kt 50.00% 1 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3167      +/-   ##
=====================================================
- Coverage              54.15%   54.09%   -0.06%     
=====================================================
  Files                   1249     1250       +1     
  Lines                  36448    36493      +45     
  Branches                3688     3697       +9     
=====================================================
+ Hits                   19737    19742       +5     
- Misses                 15287    15326      +39     
- Partials                1424     1425       +1     
Files with missing lines Coverage Δ
...a/conversation/ConversationRepositoryExtensions.kt 86.95% <100.00%> (ø)
...on/folder/ObserveConversationsFromFolderUseCase.kt 100.00% <100.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt 62.37% <50.00%> (ø)
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...lium/logic/data/conversation/ConversationFolder.kt 0.00% <0.00%> (ø)
...nversation/folders/ConversationFolderRepository.kt 86.56% <0.00%> (-7.09%) ⬇️
...e/conversation/folder/ObserveUserFoldersUseCase.kt 0.00% <0.00%> (ø)
...lium/logic/data/conversation/ConversationMapper.kt 58.02% <0.00%> (-0.13%) ⬇️
...o/conversation/folder/ConversationFolderDAOImpl.kt 75.00% <9.09%> (-13.89%) ⬇️
...lium/logic/data/conversation/ConversationFilter.kt 0.00% <0.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd8732...51f292c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants