Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to cc3, fixes new_transaction in paralel (WPB-14910) #3170

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 12, 2024

BugWPB-14910 [Android] CC 2 migration has some decryption errors after migration


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Issues when we bumped the version to 2.0 of CoreCrypto.
This version also exposes another ErrorCode, that for now we can ignore as we treat it as Generic.

Solutions

Bump to 3.0 with the fix


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Test Results

3 339 tests  ±0   3 232 ✅ ±0   5m 27s ⏱️ -3s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 062a6ae. ± Comparison against base commit 7fd041a.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.14%. Comparing base (7fd041a) to head (062a6ae).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3170      +/-   ##
=====================================================
- Coverage              54.14%   54.14%   -0.01%     
=====================================================
  Files                   1250     1250              
  Lines                  36457    36457              
  Branches                3689     3689              
=====================================================
- Hits                   19739    19738       -1     
- Misses                 15294    15296       +2     
+ Partials                1424     1423       -1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd041a...062a6ae. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/upgradecc-3-transactions
Commit report: 99baf16
Test service: kalium-jvm

✅ 0 Failed, 3232 Passed, 107 Skipped, 1m 0.53s Total Time

@yamilmedina yamilmedina added this pull request to the merge queue Dec 12, 2024
Merged via the queue into release/candidate with commit c9f091b Dec 12, 2024
22 checks passed
@yamilmedina yamilmedina deleted the chore/upgradecc-3-transactions branch December 12, 2024 07:12
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. 👕 size: XS type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants