Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for old format parser in capabilities (WPB-12022) #3173

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 12, 2024

TaskWPB-12022 [Android] API V7 related client ticket


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

V7 API changes in capabilities, add missing test to cover the retrocompat case.
Covering alternative (not modifying the serializer) for #3151 with working tests

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Test Results

3 340 tests  +1   3 233 ✅ +1   5m 23s ⏱️ -8s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit eaf8c59. ± Comparison against base commit c9f091b.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.14%. Comparing base (c9f091b) to head (eaf8c59).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3173   +/-   ##
==================================================
  Coverage              54.14%   54.14%           
==================================================
  Files                   1250     1250           
  Lines                  36457    36457           
  Branches                3689     3689           
==================================================
  Hits                   19738    19738           
+ Misses                 15296    15295    -1     
- Partials                1423     1424    +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f091b...eaf8c59. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: test/capabilities-retrocompat
Commit report: cc5b1ea
Test service: kalium-jvm

✅ 0 Failed, 3233 Passed, 107 Skipped, 59.31s Total Time

@ohassine ohassine added this pull request to the merge queue Dec 13, 2024
Merged via the queue into release/candidate with commit 6518915 Dec 13, 2024
22 checks passed
@ohassine ohassine deleted the test/capabilities-retrocompat branch December 13, 2024 09:46
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants