fix: Sending of message in empty MLS group #WPB-14747 🍒

[github-actions]

WPB-14747 [Android] Sending of messages in EMPTY MLS groups not working with latest 4.10 build

This PR was automatically cherry-picked based on the following PR:

• fix: Sending of message in empty MLS group #WPB-14747 #3176

Original PR description:

---

What's new in this PR?

Issues

When user creates empty MLS group (self user is the only member) and has only 1 client. Then sending messages always fails in such a group.

Causes (Optional)

According to logs, send message error: InvalidRequestError(errorResponse=ErrorResponse(code=400, message=Application messages at epoch 0 are not supported, label=mls-protocol-error, cause=null)).
Why epoch = 0?

How it should work: when client creates MLS group epoch set 0, after that we suppose to add some users and when do that epoch is updated. But when the group is empty, no updating epoch.
There is "workaround" for that case calling updateKeyingMaterial(idMapper.toCryptoModel(groupID)) but it didn't work because of if(userIdList.isEmpty()) but it's always false, cause userIdList includes self userId.

Solutions

Update if in internalAddMemberToMLSGroup to check not userIds but clientKeyPackageList if empty.
In that case when client creates empty MLS group clientKeyPackageList will be empty and workaround works.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 346 tests  ±0   3 239 ✅ ±0   5m 20s ⏱️ -44s
  573 suites ±0     107 💤 ±0 
  573 files   ±0       0 ❌ ±0 

Results for commit 9995ca1. ± Comparison against base commit 6fb2177.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	fix/sending_of_messages_in_empty_mls_group-cherry-pick
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	662,817.90
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	542,480,961.43
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,321,980,214.72
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,501,398.74

🐰 View full continuous benchmarking report in Bencher

[datadog-wireapp]

Datadog Report

Branch report: fix/sending_of_messages_in_empty_mls_group-cherry-pick
Commit report: a54c7c1
Test service: kalium-jvm

✅ 0 Failed, 3239 Passed, 107 Skipped, 1m 1.64s Total Time

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.13%. Comparing base (6fb2177) to head (9995ca1).

Files with missing lines	Patch %	Lines
...gic/data/conversation/MLSConversationRepository.kt	89.65%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3177      +/-   ##
===========================================
- Coverage    54.14%   54.13%   -0.01%     
===========================================
  Files         1252     1252              
  Lines        36527    36528       +1     
  Branches      3703     3703              
===========================================
  Hits         19776    19776              
- Misses       15326    15327       +1     
  Partials      1425     1425              

Files with missing lines	Coverage Δ
...gic/data/conversation/MLSConversationRepository.kt	83.75% <89.65%> (+0.03%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb2177...9995ca1. Read the comment docs.