Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused conversation id [#WPB-14256] #3183

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Dec 17, 2024

StoryWPB-14256 [Android] Call end - Event and segmentation

What's new in this PR?

Issues

I have left unused conversation id in the use case - which we have to clean up


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Test Results

3 354 tests  ±0   3 247 ✅ ±0   5m 32s ⏱️ +8s
  574 suites ±0     107 💤 ±0 
  574 files   ±0       0 ❌ ±0 

Results for commit 7d66401. ± Comparison against base commit 1ca6dfc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@m-zagorski m-zagorski enabled auto-merge December 17, 2024 12:02
@m-zagorski m-zagorski added this pull request to the merge queue Dec 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.10%. Comparing base (1ca6dfc) to head (7d66401).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3183   +/-   ##
========================================
  Coverage    54.10%   54.10%           
========================================
  Files         1256     1256           
  Lines        36659    36659           
  Branches      3726     3726           
========================================
  Hits         19834    19834           
- Misses       15385    15386    +1     
+ Partials      1440     1439    -1     
Files with missing lines Coverage Δ
...usecase/ObserveRecentlyEndedCallMetadataUseCase.kt 0.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca6dfc...7d66401. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/remove-unused-conversation-id
Commit report: c65db7e
Test service: kalium-jvm

✅ 0 Failed, 3247 Passed, 107 Skipped, 1m 1.82s Total Time

Merged via the queue into develop with commit 69621bc Dec 17, 2024
23 checks passed
@m-zagorski m-zagorski deleted the fix/remove-unused-conversation-id branch December 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants