Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Provide team url use case through user scope [#WPB-14873] #3184

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Dec 17, 2024

TaskWPB-14873 [Android] No access to team management from application

What's new in this PR?

Issues

We need to fetch team url - but the use case was not provided through user scope

Solutions

Provide use case through user scope :)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Test Results

3 354 tests  ±0   3 247 ✅ ±0   5m 52s ⏱️ +16s
  574 suites ±0     107 💤 ±0 
  574 files   ±0       0 ❌ ±0 

Results for commit 2e8b88b. ± Comparison against base commit 69621bc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.10%. Comparing base (69621bc) to head (2e8b88b).

Files with missing lines Patch % Lines
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3184      +/-   ##
===========================================
- Coverage    54.10%   54.10%   -0.01%     
===========================================
  Files         1256     1256              
  Lines        36659    36661       +2     
  Branches      3726     3726              
===========================================
- Hits         19836    19834       -2     
- Misses       15384    15388       +4     
  Partials      1439     1439              
Files with missing lines Coverage Δ
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69621bc...2e8b88b. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/provide-user-team-use-case
Commit report: acfacf5
Test service: kalium-jvm

✅ 0 Failed, 3247 Passed, 107 Skipped, 1m 2.58s Total Time

@m-zagorski m-zagorski enabled auto-merge December 17, 2024 13:49
@m-zagorski m-zagorski added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit 91b8319 Dec 17, 2024
24 checks passed
@m-zagorski m-zagorski deleted the chore/provide-user-team-use-case branch December 17, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: XS type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants