Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add getSenderNameByMessageId useCase WPB-11723 #3186

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: Add getSenderNameByMessageId useCase WPB-11723 #3186

wants to merge 4 commits into from

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 17, 2024 •
edited by github-actions bot
Loading

StoryWPB-11723 [Android] Playback improvement - 1 - Scroll / Duration / Speed

What's new in this PR?

Need an option to get senders name by MessageId.
Of course we could use existed GetMessageByIdUseCase and get sender from it. But this useCase trigger query to a lot of tables, so better to add some small query and UseCase.

@borichellow borichellow self-assigned this Dec 17, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 17, 2024
@borichellow borichellow mentioned this pull request Dec 17, 2024
Open
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Test Results

3 360 tests  +6   3 253 ✅ +6   5m 31s ⏱️ -10s
  575 suites +1     107 💤 ±0 
  575 files   +1       0 ❌ ±0 

Results for commit c0aef5c. ± Comparison against base commit 91b8319.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

🐰 Bencher Report

Branchfeat/add_get_sender_name_by_message_id_use_case
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD		663,594.42
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD		543,597,527.63
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD		1,314,341,216.60
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD		21,458,078.19
🐰 View full continuous benchmarking report in Bencher

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 17, 2024 •
edited
Loading

Datadog Report

Branch report: feat/add_get_sender_name_by_message_id_use_case
Commit report: d470122
Test service: kalium-jvm

✅ 0 Failed, 3253 Passed, 107 Skipped, 1m 2.46s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.11%. Comparing base (91b8319) to head (c0aef5c).

Files with missing lines Patch % Lines
...ire/kalium/logic/data/message/MessageRepository.kt 0.00% 1 Missing ⚠️
...feature/message/GetSenderNameByMessageIdUseCase.kt 90.90% 1 Missing ⚠️
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% 1 Missing ⚠️
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3186      +/-   ##
===========================================
+ Coverage    54.10%   54.11%   +0.01%     
===========================================
  Files         1256     1257       +1     
  Lines        36661    36679      +18     
  Branches      3726     3727       +1     
===========================================
+ Hits         19834    19848      +14     
- Misses       15387    15390       +3     
- Partials      1440     1441       +1
Files with missing lines Coverage Δ
.../wire/kalium/persistence/dao/message/MessageDAO.kt 100.00% <ø> (ø)
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 77.84% <100.00%> (+0.12%) ⬆️
...ire/kalium/logic/data/message/MessageRepository.kt 49.40% <0.00%> (-0.20%) ⬇️
...feature/message/GetSenderNameByMessageIdUseCase.kt 90.90% <90.90%> (ø)
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% <0.00%> (ø)
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 70.67% <75.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b8319...c0aef5c. Read the comment docs.

@borichellow borichellow mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@vitorhugods vitorhugods Awaiting requested review from vitorhugods

@Garzas Garzas Awaiting requested review from Garzas

At least 2 approving reviews are required to merge this pull request.

Assignees

@borichellow borichellow

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borichellow @codecov-commenter @MohamadJaara