fix: infinite profile loading screen when user cannot be added (WPB-14842)

[sergeibakhtiarov]

WPB-14842 [Android] User profile loading indefinitely when trying to connect to a user with QR code when I am not allowed to connect

https://wearezeta.atlassian.net/browse/WPB-14842

What's new in this PR?

Issues

When trying to add user via QR code and this user cannot be added (e.g. anta user to beta app) then profile screen is showing infinite loading progress.

Causes (Optional)

The scenario when user is not found locally and network fetch returns success result with no users is not handled. The repository is storing fetched users in the database and UI will get user from the database. In this flow no users are saved in the database and UI keeps showing progress because no error was returned.

Solutions

Add a boolean flag (instead of Unit) to indicate if actual users were found. Use this flag to return error if no users were found on server.

How to Test

Try to add an anta user to beta app via QR code.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 355 tests  +1   3 248 ✅ +1   5m 54s ⏱️ +13s
  574 suites ±0     107 💤 ±0 
  574 files   ±0       0 ❌ ±0 

Results for commit 48bb02d. ± Comparison against base commit 91b8319.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	fix/infinite-profile-loading
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	659,699.25
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	602,228,226.88
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,326,772,506.17
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,814,954.28

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.10%. Comparing base (91b8319) to head (48bb02d).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3187   +/-   ##
========================================
  Coverage    54.10%   54.10%           
========================================
  Files         1256     1256           
  Lines        36661    36661           
  Branches      3726     3727    +1     
========================================
  Hits         19834    19834           
- Misses       15387    15388    +1     
+ Partials      1440     1439    -1     

Files with missing lines	Coverage Δ
.../com/wire/kalium/logic/data/user/UserRepository.kt	68.04% <100.00%> (ø)
...logic/feature/message/MessageSendFailureHandler.kt	87.71% <100.00%> (ø)
...alium/logic/feature/user/ObserveUserInfoUseCase.kt	84.37% <ø> (ø)

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b8319...48bb02d. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/infinite-profile-loading
Commit report: 32b86ec
Test service: kalium-jvm

✅ 0 Failed, 3248 Passed, 107 Skipped, 1m 2.35s Total Time