fix: crash when self user is mentioned multiple times in last message [WPB-15157]

[saleniuk]

WPB-15157 App crashes after receiving links in a group chat

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

When self user receives a message in which he/she is mentioned more than once, the app crashes as long as this message is the last one for the given conversation:
java.lang.IllegalArgumentException: Key "[email protected]" was already used

Causes (Optional)

When making a query, we left-join MessageMention with self_user_id or null if there are no mentions in last message for self user, however, this table has primary key consisting of not only message_id and conversation_id which means that there can be more than one mention in a given last message, moreover - self user can be mentioned more than once and that's what happens - self user has two mentions in last conversation message and then left-join creates two rows for the given conversation with both mentions.

Solutions

Count self user mentions and group results by conversation_id so that we're sure that there will only be a single row for each conversation.
When I was analysing and making tests of different approaches to find optimal one back then (#3098) I also noticed that having group by conversation_id doesn't affect the execution time, so it should be safe to use that.

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 272 tests   3 165 ✅  4m 42s ⏱️
  558 suites    107 💤
  558 files        0 ❌

Results for commit 3870c25.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

Branch report: fix/multiple-self-mentions-in-last-message-crash
Commit report: 222be71
Test service: kalium-jvm

✅ 0 Failed, 3165 Passed, 107 Skipped, 33.6s Total Time

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/android-cycle-4.9@790b885). Learn more about missing BASE report.

Additional details and impacted files

@@                     Coverage Diff                      @@
##             release/android-cycle-4.9    #3192   +/-   ##
============================================================
  Coverage                             ?   52.67%           
============================================================
  Files                                ?     1323           
  Lines                                ?    51749           
  Branches                             ?     4804           
============================================================
  Hits                                 ?    27257           
  Misses                               ?    22526           
  Partials                             ?     1966           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790b885...3870c25. Read the comment docs.