Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add error log for long storage requests [#WPB-11603] #3225

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Jan 13, 2025

BugWPB-11603 [Android] App very slow on "decrypting messages"

https://wearezeta.atlassian.net/browse/WPB-11603

What's new in this PR?

Issues

Slow sync issue could be caused by a slow database access. Logging long database operations will help to approve or reject this hypothesis.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Test Results

3 387 tests  ±0   3 279 ✅ ±0   5m 23s ⏱️ -32s
  581 suites ±0     108 💤 ±0 
  581 files   ±0       0 ❌ ±0 

Results for commit 140fe4d. ± Comparison against base commit d54cc28.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.47%. Comparing base (d54cc28) to head (140fe4d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3225      +/-   ##
===========================================
- Coverage    54.49%   54.47%   -0.02%     
===========================================
  Files         1264     1264              
  Lines        36858    36864       +6     
  Branches      3738     3740       +2     
===========================================
- Hits         20085    20083       -2     
- Misses       15363    15370       +7     
- Partials      1410     1411       +1     
Files with missing lines Coverage Δ
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 31.39% <0.00%> (-1.14%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54cc28...140fe4d. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/slow-sync-investigation
Commit report: efc7e16
Test service: kalium-jvm

✅ 0 Failed, 3279 Passed, 108 Skipped, 59.94s Total Time

@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
@MohamadJaara
Copy link
Member

@sergeibakhtiarov after merging db logger is this one needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants