fix: crash when self user is mentioned multiple times in last message [WPB-15157] 🍒 🍒 #3234
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
saleniuk
requested review from
a team,
yamilmedina,
alexandreferris,
MohamadJaara,
saleniuk and
mathias-niboulies
and removed request for
a team
|
Bencher Report| Branch | fix/multiple-self-mentions-in-last-message-crash-rc-cherry-pick |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 682.11 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 602,000.23 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,349,834.92 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 22,270.52 |
Datadog ReportBranch report: ✅ 0 Failed, 3297 Passed, 108 Skipped, 1m 1.4s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3234 +/- ##
===========================================
- Coverage 54.44% 54.44% -0.01%
===========================================
Files 1271 1271
Lines 37018 37018
Branches 3753 3753
===========================================
- Hits 20156 20154 -2
- Misses 15445 15447 +2
Partials 1417 1417 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
|
In order to keep migrations order between RC (4.10) and dev (4.11), migrations that appear only in dev were moved forward so that the one added by this fix for RC (#3238) is in right place and all of them are in correct order:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
saleniuk
deleted the
fix/multiple-self-mentions-in-last-message-crash-rc-cherry-pick
branch
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was manually cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When self user receives a message in which he/she is mentioned more than once, the app crashes as long as this message is the last one for the given conversation:
java.lang.IllegalArgumentException: Key "[email protected]" was already usedCauses (Optional)
When making a query, we left-join
MessageMentionwith self_user_id or null if there are no mentions in last message for self user, however, this table has primary key consisting of not onlymessage_idandconversation_idwhich means that there can be more than one mention in a given last message, moreover - self user can be mentioned more than once and that's what happens - self user has two mentions in last conversation message and then left-join creates two rows for the given conversation with both mentions.Solutions
Count self user mentions and group results by
conversation_idso that we're sure that there will only be a single row for each conversation.When I was analysing and making tests of different approaches to find optimal one back then (#3098) I also noticed that having
group by conversation_iddoesn't affect the execution time, so it should be safe to use that.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.