fix: wrong migrations order between 4.9 and 4.10 [WPB-15157] 🍒 #3240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When cherry-picking the fix for multiple mentions from 4.9 to RC 4.10, the order of migrations were changed - in 4.9 migration related to this fix was added as
91.sqm
but in 4.10 as95.sqm
, so it means that when updating the app from 4.9 to 4.10, the app will lose migration that's implemented in 4.10 as91.sqm
because migration with number 91 has already been executed in 4.9.Solutions
Migration from
91.sqm
is about creatingConversationFolder
andLabeledConversation
, so to fix it, additional migration96.sqm
was created in order to add these tables if they don't yet exist.Note: this new migration also needs to be added to dev (4.11) to maintain the order there.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.