Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong migrations order between 4.9 and 4.10 [WPB-15157] 🍒 #3240

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-15157 App crashes after receiving links in a group chat


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When cherry-picking the fix for multiple mentions from 4.9 to RC 4.10, the order of migrations were changed - in 4.9 migration related to this fix was added as 91.sqm but in 4.10 as 95.sqm, so it means that when updating the app from 4.9 to 4.10, the app will lose migration that's implemented in 4.10 as 91.sqm because migration with number 91 has already been executed in 4.9.

Solutions

Migration from 91.sqm is about creating ConversationFolder and LabeledConversation, so to fix it, additional migration 96.sqm was created in order to add these tables if they don't yet exist.
Note: this new migration also needs to be added to dev (4.11) to maintain the order there.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch DO NOT CHERRY PICK echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. type: bug / fix 🐞 👕 size: S labels Jan 22, 2025
@saleniuk saleniuk closed this Jan 22, 2025
@saleniuk saleniuk deleted the fix/wrong-migration-order-between-4.9-and-4.10-cherry-pick branch January 22, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch DO NOT CHERRY PICK echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant