Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when requesting focus in create account screen #2233

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

cherry pick

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Test Results

600 tests  ±0   599 ✔️ ±0   8m 19s ⏱️ + 2m 10s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit 725d428. ± Comparison against base commit fd815b3.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 756 failed.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara requested review from a team, typfel, yamilmedina, borichellow, ohassine and saleniuk and removed request for a team September 13, 2023 11:04
@AndroidBob
Copy link
Collaborator

Build 757 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 14, 2023
Merged via the queue into develop with commit e926090 Sep 14, 2023
12 checks passed
@MohamadJaara MohamadJaara deleted the fix/crash-when-requesting-focus-in-create-account-screen-dev branch September 14, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants