Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max accounts dialog prevent dismiss (WPB-4818) #2261

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
CONFLICT (modify/delete): app/src/main/kotlin/com/wire/android/ui/common/dialogs/MaxAccountsReachedDialog.kt deleted in HEAD and modified in b4f76b7 (fix: max accounts dialog prevent dismiss (WPB-4818) (#2260)). Version b4f76b7 (fix: max accounts dialog prevent dismiss (WPB-4818) (#2260)) of app/src/main/kotlin/com/wire/android/ui/common/dialogs/MaxAccountsReachedDialog.kt left in tree.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Dialog can be dismissed bypassing the max accounts creation.

Causes (Optional)

Max accounts flag not respected

Solutions

Make the dialog stick, not dismiss outside.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Sep 22, 2023
@yamilmedina yamilmedina changed the base branch from develop to fix/max-accounts-handling-cherry-pick September 22, 2023 13:20
@yamilmedina yamilmedina deleted the fix/max-accounts-dialog-cherry-pick branch September 22, 2023 13:21
@AndroidBob
Copy link
Collaborator

Build 916 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants