fix: max accounts dialog prevent dismiss (WPB-4818) #2261
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
CONFLICT (modify/delete): app/src/main/kotlin/com/wire/android/ui/common/dialogs/MaxAccountsReachedDialog.kt deleted in HEAD and modified in b4f76b7 (fix: max accounts dialog prevent dismiss (WPB-4818) (#2260)). Version b4f76b7 (fix: max accounts dialog prevent dismiss (WPB-4818) (#2260)) of app/src/main/kotlin/com/wire/android/ui/common/dialogs/MaxAccountsReachedDialog.kt left in tree.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Dialog can be dismissed bypassing the max accounts creation.
Causes (Optional)
Max accounts flag not respected
Solutions
Make the dialog stick, not dismiss outside.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.