-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: self deleting ping has no sound (WPB-3175) #2269
Conversation
Build 954 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2269 +/- ##
=============================================
- Coverage 40.39% 40.36% -0.03%
- Complexity 1011 1012 +1
=============================================
Files 318 318
Lines 11625 11635 +10
Branches 1542 1546 +4
=============================================
+ Hits 4696 4697 +1
- Misses 6489 6497 +8
- Partials 440 441 +1
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 966 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Self-deleting pings (knock message) has no sound (both from notification or inside conversation)
Causes (Optional)
As it was being "hidden" behind self deleting message it wouldn't map correctly to Knock/Ping type
Solutions
Correctly map knock/ping from self deleting message to self deleting ping in order to play the sound on notification and inside conversation.
Testing
How to Test
Phone must NOT be on silent mode
On Conversation List:
Receive self deleting ping => should play a sound
Inside Conversation
Receive self deleting ping => should play a sound
Needs before:
[ ] - wireapp/kalium#2086