Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore negative mention index #2274

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Sep 26, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry pick from #2270

@Garzas Garzas requested a review from a team September 26, 2023 15:04
@Garzas Garzas self-assigned this Sep 26, 2023
@Garzas Garzas requested review from typfel, gongracr, alexandreferris, MohamadJaara and mchenani and removed request for a team September 26, 2023 15:04
@tmspzz tmspzz changed the title Fix: ignore negative mention index fix: ignore negative mention index Sep 26, 2023
@Garzas Garzas enabled auto-merge (squash) September 26, 2023 15:09
@Garzas Garzas merged commit 6135347 into release/cycle-4.3 Sep 26, 2023
6 of 7 checks passed
@Garzas Garzas deleted the fix/ignore-negative-mention-index branch September 26, 2023 15:19
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1004 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants