Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DiskReadViolation related database check #2276

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We are checking the existence of old database on main thread

Solutions

Use IO dispatcher

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from MohamadJaara, Garzas, saleniuk, a team, typfel and gongracr and removed request for a team September 27, 2023 12:36
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2276 (eef2f6b) into develop (f65934a) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             develop    #2276      +/-   ##
=============================================
+ Coverage      40.50%   40.51%   +0.01%     
+ Complexity      1015     1014       -1     
=============================================
  Files            318      318              
  Lines          11665    11669       +4     
  Branches        1551     1552       +1     
=============================================
+ Hits            4725     4728       +3     
  Misses          6496     6496              
- Partials         444      445       +1     
Files Coverage Δ
...lin/com/wire/android/migration/MigrationManager.kt 41.88% <60.00%> (+0.70%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65934a...eef2f6b. Read the comment docs.

@github-actions
Copy link
Contributor

Test Results

623 tests  ±0   622 ✔️ ±0   4m 49s ⏱️ - 2m 25s
  89 suites ±0       1 💤 ±0 
  89 files   ±0       0 ±0 

Results for commit eef2f6b. ± Comparison against base commit f65934a.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1021 succeeded.

The build produced the following APK's:

@gongracr gongracr added this pull request to the merge queue Sep 27, 2023
Merged via the queue into develop with commit 4750dbe Sep 27, 2023
12 checks passed
@gongracr gongracr deleted the diskReadViolation branch September 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants