Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enter app lock passcode UI and logic [WPB-4695] #2278

Merged
merged 7 commits into from
Oct 11, 2023
Merged

feat: add enter app lock passcode UI and logic [WPB-4695] #2278

merged 7 commits into from
Oct 11, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Sep 27, 2023 •
edited by github-actions bot
Loading

StoryWPB-4695 [Android] Toggle app lock from the app settings (Password only)

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Screen that allows user to enter the app lock passcode.
Logic to keep track of when the app is being put into background and to show such screen after specific time passed.

Testing

How to Test

In privacy settings set the app lock passcode and put the app into background.

Attachments (Optional)

In the video below the timestamp was changed from 60s to 5s to make it easier to record and show this logic.

enterapplock.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk changed the title feat: enter app lock [WPB-4695] feat: enter app lock passcode [WPB-4695] Sep 27, 2023
@saleniuk saleniuk changed the title feat: enter app lock passcode [WPB-4695] feat: add enter app lock passcode UI and logic [WPB-4695] Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023 •
edited
Loading

Test Results

641 tests  +12   641 ✔️ +12   8m 27s ⏱️ +8s
  93 suites +  1       0 💤 ±  0 
  93 files   +  1       0 ❌ ±  0 

Results for commit 7723adc. ± Comparison against base commit b813a5f.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1033 failed.

@AndroidBob
Copy link
Collaborator

Build 1034 failed.

@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #2278 (7723adc) into develop (d2fcaa7) will decrease coverage by 0.38%.
Report is 2 commits behind head on develop.
The diff coverage is 15.60%.

@@              Coverage Diff              @@
##             develop    #2278      +/-   ##
=============================================
- Coverage      41.42%   41.04%   -0.38%     
- Complexity      1046     1048       +2     
=============================================
  Files            324      328       +4     
  Lines          11731    11902     +171     
  Branches        1560     1586      +26     
=============================================
+ Hits            4859     4885      +26     
- Misses          6403     6547     +144     
- Partials         469      470       +1
Files Coverage Δ
...ire/android/feature/ObserveAppLockConfigUseCase.kt 90.00% <100.00%> (ø)
...ire/android/ui/home/appLock/LockCodeTimeManager.kt 96.15% <96.15%> (ø)
...tlin/com/wire/android/datastore/GlobalDataStore.kt 12.50% <16.66%> (+0.63%) ⬆️
...d/ui/emoji/DraggableByHandleBottomSheetBehavior.kt 0.00% <0.00%> (ø)
.../android/ui/home/appLock/EnterLockCodeViewState.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)
...droid/ui/emoji/HandleDraggableBottomSheetDialog.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b813a5f...7723adc. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1036 succeeded.

The build produced the following APK's:

vitorhugods
vitorhugods approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just wonder if LockCodeTimeManager will have some tests.

app/src/main/kotlin/com/wire/android/ui/home/appLock/LockCodeTimeManager.kt Outdated Show resolved Hide resolved
@AndroidBob
Copy link
Collaborator

Build 1227 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, gongracr, yamilmedina, MohamadJaara and Garzas and removed request for a team October 11, 2023 09:55
@saleniuk saleniuk requested a review from ohassine October 11, 2023 09:55
@AndroidBob
Copy link
Collaborator

Build 1228 succeeded.

The build produced the following APK's:

alexandreferris
alexandreferris approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loooking 👌🏻

gongracr
gongracr approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 👏 LGTM 🍪

@saleniuk saleniuk added this pull request to the merge queue Oct 11, 2023
Merged via the queue into develop with commit 016560c Oct 11, 2023
11 checks passed
@saleniuk saleniuk deleted the feat/enter-app-lock branch October 11, 2023 11:11
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@gongracr gongracr gongracr approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina yamilmedina was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@saleniuk saleniuk

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saleniuk @AndroidBob @gongracr @alexandreferris @vitorhugods