Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the new CameraPreviewBuilder to get CameraPreview #2291

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

AVS updated their API to use PreviewView from CameraX. Here the PR wireapp/kalium#2108

So we need to adapt those changes by using CameraPreviewBuilder

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, yamilmedina, MohamadJaara, vitorhugods, Garzas and saleniuk and removed request for a team September 29, 2023 14:14
@AndroidBob
Copy link
Collaborator

Build 1075 failed.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Test Results

622 tests  ±0   621 ✔️ ±0   6m 18s ⏱️ - 2m 46s
  89 suites ±0       1 💤 ±0 
  89 files   ±0       0 ±0 

Results for commit 8f42a09. ± Comparison against base commit b7d4c8d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1076 succeeded.

The build produced the following APK's:

@ohassine ohassine enabled auto-merge September 29, 2023 15:30
@ohassine ohassine added this pull request to the merge queue Sep 29, 2023
@ohassine ohassine removed this pull request from the merge queue due to a manual request Sep 29, 2023
@ohassine ohassine added this pull request to the merge queue Sep 29, 2023
Merged via the queue into develop with commit 30f7cac Sep 29, 2023
12 checks passed
@ohassine ohassine deleted the camera_preview branch September 29, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants