Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated user settings screen with correct copy for typing indicator [WPB-4592] #2294

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: updated user settings screen with correct copy for typing indicator [WPB-4592] #2294

merged 1 commit into from
Oct 2, 2023

Conversation

gongracr
Copy link
Contributor

@gongracr gongracr commented Oct 2, 2023 •
edited by github-actions bot
Loading

StoryWPB-4592 [Android] Typing indicator user settings screen

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Wrong copy selected as description for typing indicator inside the user privacy settings screen

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@gongracr gongracr enabled auto-merge October 2, 2023 14:17
@gongracr gongracr added this pull request to the merge queue Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Test Results

623 tests  ±0   622 ✔️ ±0   7m 15s ⏱️ +19s
  90 suites ±0       1 💤 ±0 
  90 files   ±0       0 ❌ ±0 

Results for commit 4313e1c. ± Comparison against base commit 7884f76.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit d7aef43 Oct 2, 2023
12 checks passed
@gongracr gongracr deleted the fix/wrong_copy branch October 2, 2023 14:54
@AndroidBob
Copy link
Collaborator

Build 1104 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohassine ohassine ohassine approved these changes

@Garzas Garzas Garzas approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@mchenani mchenani Awaiting requested review from mchenani

Assignees

@gongracr gongracr

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gongracr @AndroidBob @yamilmedina @Garzas @ohassine