Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: User verification status Proteus (WPB-1775) #2299

Merged
merged 13 commits into from
Oct 13, 2023
Merged

feat: User verification status Proteus (WPB-1775) #2299

merged 13 commits into from
Oct 13, 2023

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Oct 4, 2023 •
edited by github-actions bot
Loading

StoryWPB-1775 [Proteus] show that a user is verified

What's new in this PR?

If all the users clients are verified (in Proteus protocol), then this user is Verified and should be displayed in the corresponding way (blue shield icon, see the screenshots).

Waiting the kalium PR

Attachments (Optional)

Screenshot 2023-10-04 at 14 42 37 Screenshot 2023-10-04 at 14 42 24 Screenshot 2023-10-04 at 14 42 15

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@borichellow borichellow changed the title feat: User verification status Proteus (WPB01775) feat: User verification status Proteus (WPB-1775) Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

Test Results

644 tests  ±0   644 ✔️ ±0   7m 19s ⏱️ + 2m 34s
  93 suites ±0       0 💤 ±0 
  93 files   ±0       0 ❌ ±0 

Results for commit 7c9e24f. ± Comparison against base commit e096a5b.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1141 failed.

@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #2299 (e419dd3) into develop (e096a5b) will increase coverage by 0.13%.
The diff coverage is 42.85%.

❗ Current head e419dd3 differs from pull request most recent head 716ce89. Consider uploading reports for the commit 716ce89 to get more accurate results

@@              Coverage Diff              @@
##             develop    #2299      +/-   ##
=============================================
+ Coverage      41.28%   41.41%   +0.13%     
+ Complexity      1050     1047       -3     
=============================================
  Files            328      324       -4     
  Lines          11918    11737     -181     
  Branches        1588     1561      -27     
=============================================
- Hits            4920     4861      -59     
+ Misses          6530     6406     -124     
- Partials         468      470       +2
Files Coverage Δ
.../android/ui/authentication/devices/model/Device.kt 94.44% <100.00%> (ø)
...ations/details/participants/model/UIParticipant.kt 100.00% <100.00%> (ø)
...roid/ui/userprofile/other/OtherUserProfileState.kt 86.84% <100.00%> (+0.35%) ⬆️
...tlin/com/wire/android/migration/MigrationMapper.kt 0.00% <0.00%> (ø)
...lin/com/wire/android/mapper/UIParticipantMapper.kt 41.37% <0.00%> (-2.26%) ⬇️

... and 9 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e096a5b...716ce89. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1142 succeeded.

The build produced the following APK's:

gongracr
gongracr approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff soldier 🫡🛡️

@AndroidBob
Copy link
Collaborator

Build 1165 failed.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1180 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@borichellow borichellow added this pull request to the merge queue Oct 12, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1265 succeeded.

The build produced the following APK's:

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 12, 2023
@borichellow borichellow added this pull request to the merge queue Oct 13, 2023
Merged via the queue into develop with commit d3d6bf7 Oct 13, 2023
10 checks passed
@borichellow borichellow deleted the feat/user_verification_status_proteus branch October 13, 2023 07:38
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchenani mchenani mchenani approved these changes

@gongracr gongracr gongracr approved these changes

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

@vitorhugods vitorhugods Awaiting requested review from vitorhugods

@Garzas Garzas Awaiting requested review from Garzas

Assignees

@borichellow borichellow

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@borichellow @CLAassistant @AndroidBob @gongracr @mchenani