feat: add confirmation dialog archiving [WPB-4434] #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat/add_confirmation_dialog_archiving # Conflicts: # app/src/test/kotlin/com/wire/android/ui/home/conversationslist/ConversationListViewModelTest.kt
Test Results629 tests ±0 629 ✔️ ±0 7m 25s ⏱️ - 2m 20s Results for commit 87055a0. ± Comparison against base commit 3522b4a. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Build 1150 failed. |
ohassine
approved these changes
Oct 4, 2023
app/src/main/kotlin/com/wire/android/ui/home/conversationslist/ConversationListViewModel.kt
Outdated
Show resolved
Hide resolved
…to feat/add_confirmation_dialog_archiving
Codecov Report
@@ Coverage Diff @@
## develop #2300 +/- ##
=============================================
+ Coverage 41.36% 41.42% +0.05%
Complexity 1046 1046
=============================================
Files 324 324
Lines 11731 11731
Branches 1554 1560 +6
=============================================
+ Hits 4853 4859 +6
+ Misses 6410 6403 -7
- Partials 468 469 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1154 succeeded. The build produced the following APK's: |
alexandreferris
approved these changes
Oct 5, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Before archiving a conversation, since it is a semi-critical action, we need to confirm that the user didn't tap on the archiving option by mistake by showing a confirmation dialog.
How to Test
Try to archive a conversation by long tapping a conversation item in the home screen or by navigating to the group or other users details screen and clicking on the options icon (three dots)
Attachments (Optional)
Grabacion.de.pantalla.2023-10-04.a.las.16.36.36.mov
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.