Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not showing dialog when archiving users from user profile screen [WPB-4993] #2304

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

gongracr
Copy link
Contributor

@gongracr gongracr commented Oct 6, 2023

BugWPB-4993 [Android] Issue when archiving private user from profile screen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We were not showing any dialog nor performing any action when trying to archive a conversation of another user from the user profile details screen. The reason was because I had forgotten to add the archive confirmation dialog component on the OtherUserProfileScreen

Solutions

Add the dialog and handle the logic.


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@gongracr gongracr changed the title fix: not showing dialog when archiving users from user profile screen fix: not showing dialog when archiving users from user profile screen [WPB-4993] Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2304 (547a1d4) into develop (6caf28e) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             develop    #2304   +/-   ##
==========================================
  Coverage      41.42%   41.42%           
  Complexity      1046     1046           
==========================================
  Files            324      324           
  Lines          11731    11731           
  Branches        1560     1560           
==========================================
  Hits            4859     4859           
  Misses          6403     6403           
  Partials         469      469           
Files Coverage Δ
...serprofile/other/OtherUserProfileEventsHandlers.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6caf28e...547a1d4. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Test Results

629 tests  ±0   629 ✔️ ±0   8m 1s ⏱️ + 3m 49s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ±0 

Results for commit 547a1d4. ± Comparison against base commit 6caf28e.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1181 succeeded.

The build produced the following APK's:

@gongracr gongracr enabled auto-merge October 6, 2023 14:41
@gongracr gongracr added this pull request to the merge queue Oct 9, 2023
Merged via the queue into develop with commit 480af5a Oct 9, 2023
14 checks passed
@gongracr gongracr deleted the fix/archiving_issues branch October 9, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants