Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: source updated from crowdin #2305

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Conversation

yamilmedina
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [] contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Enable workflow to be run by translators, so we can update source (default: strings.xml) from crowdin


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from gongracr October 9, 2023 10:17
Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very bueno! 🍘

.github/workflows/crowdin-source-updater.yml Outdated Show resolved Hide resolved
on:
push:
branches: [ "chore/crowdin-source-updater" ] # Delete after tst.
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove or is it needed for the GH action to run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we need the workflow_dispatch so we can trigger it manually, I removed the push block tho, the test ran successfully

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we can trigger it manually

Who, exactly, and how? We, developers, by hitting the button in Actions, or we have some more stuff going on?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Test Results

629 tests  ±0   629 ✔️ ±0   6m 27s ⏱️ - 6m 33s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ±0 

Results for commit 2b3b425. ± Comparison against base commit 480af5a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1189 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina requested review from a team, alexandreferris, borichellow, vitorhugods and Garzas and removed request for a team October 9, 2023 12:05
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small question

on:
push:
branches: [ "chore/crowdin-source-updater" ] # Delete after tst.
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we can trigger it manually

Who, exactly, and how? We, developers, by hitting the button in Actions, or we have some more stuff going on?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina
Copy link
Contributor Author

yamilmedina commented Oct 9, 2023

LGTM, just small question

It could be us, as developers, but we mainly do this by updating the code directly. The intended use case for this, would be 99% for Astrid if she wants to pull some translations made to the base strings.xml on crowdin without needing to do it by code or having a developer to do it =)

@yamilmedina yamilmedina added this pull request to the merge queue Oct 9, 2023
@AndroidBob
Copy link
Collaborator

Build 1196 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit fe24d15 Oct 9, 2023
11 checks passed
@yamilmedina yamilmedina deleted the chore/crowdin-source-updater branch October 9, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants