-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: source updated from crowdin #2305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very bueno! 🍘
on: | ||
push: | ||
branches: [ "chore/crowdin-source-updater" ] # Delete after tst. | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove or is it needed for the GH action to run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we need the workflow_dispatch
so we can trigger it manually, I removed the push block tho, the test ran successfully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we can trigger it manually
Who, exactly, and how? We, developers, by hitting the button in Actions
, or we have some more stuff going on?
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1189 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small question
on: | ||
push: | ||
branches: [ "chore/crowdin-source-updater" ] # Delete after tst. | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we can trigger it manually
Who, exactly, and how? We, developers, by hitting the button in Actions
, or we have some more stuff going on?
APKs built during tests are available here. Scroll down to Artifacts! |
It could be us, as developers, but we mainly do this by updating the code directly. The intended use case for this, would be 99% for Astrid if she wants to pull some translations made to the base |
Build 1196 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Enable workflow to be run by translators, so we can update source (default:
strings.xml)
from crowdinPR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.