Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mls): navigate to migrated conversation [WPB-4705] #2327

Conversation

typfel
Copy link
Member

@typfel typfel commented Oct 15, 2023

TaskWPB-4705 [Android] Observe & navigate to active 1-1 conversation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Re-opening #2317 since it got due to a force push.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

one-on-one conversation

This commit introduces a new ViewModel `ConversationMigrationViewModel.kt` for tracking conversation migrations. It observes details of a conversation and checks if this conversation was migrated to a different one-on-one conversation. If it was, it updates the target conversation with the ID of the active one-on-one conversation.
@typfel typfel merged commit 5043e6a into feat/migration-system-messages Oct 15, 2023
6 checks passed
@typfel typfel deleted the feat/mls/navigate-to-migrated-conversation branch October 15, 2023 22:17
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

typfel added a commit that referenced this pull request Oct 15, 2023
@typfel typfel mentioned this pull request Oct 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants