-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add logger with userid and clientid #2334
feat: add logger with userid and clientid #2334
Conversation
…serid-and-clientid-cherry-pick
Codecov Report
@@ Coverage Diff @@
## develop #2334 +/- ##
=============================================
- Coverage 41.25% 41.24% -0.01%
Complexity 1058 1058
=============================================
Files 331 332 +1
Lines 12031 12032 +1
Branches 1596 1594 -2
=============================================
Hits 4963 4963
- Misses 6593 6594 +1
Partials 475 475
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1347 succeeded. The build produced the following APK's: |
…serid-and-clientid-cherry-pick # Conflicts: # kalium
…serid-and-clientid-cherry-pick
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1375 succeeded. The build produced the following APK's: |
Build 1380 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Currently logs are not associated with specific user and client which makes debugging harder.
Solutions
Create a logger in user scope that can pass userId and clientId with each log.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.