Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logger with userid and clientid #2334

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

saleniuk
Copy link
Contributor

Cherry pick from the original PR:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently logs are not associated with specific user and client which makes debugging harder.

Solutions

Create a logger in user scope that can pass userId and clientId with each log.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2334 (1e618bf) into develop (15e4e80) will decrease coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 4.16%.

@@              Coverage Diff              @@
##             develop    #2334      +/-   ##
=============================================
- Coverage      41.25%   41.24%   -0.01%     
  Complexity      1058     1058              
=============================================
  Files            331      332       +1     
  Lines          12031    12032       +1     
  Branches        1596     1594       -2     
=============================================
  Hits            4963     4963              
- Misses          6593     6594       +1     
  Partials         475      475              
Files Coverage Δ
...d/ui/authentication/login/sso/LoginSSOViewModel.kt 71.71% <100.00%> (ø)
...in/com/wire/android/ui/debug/UserDebugViewModel.kt 0.00% <0.00%> (ø)
app/src/main/kotlin/com/wire/android/AppLogger.kt 0.00% <0.00%> (ø)
.../migration/feature/MigrateActiveAccountsUseCase.kt 1.66% <0.00%> (ø)
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311b589...1e618bf. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Test Results

649 tests   649 ✔️  16m 8s ⏱️
  94 suites      0 💤
  94 files        0

Results for commit 1e618bf.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, alexandreferris, MohamadJaara, vitorhugods, mchenani and ohassine and removed request for a team October 16, 2023 16:33
@AndroidBob
Copy link
Collaborator

Build 1347 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1375 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina enabled auto-merge October 17, 2023 16:04
@yamilmedina yamilmedina added this pull request to the merge queue Oct 17, 2023
@AndroidBob
Copy link
Collaborator

Build 1380 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 3eeea52 Oct 17, 2023
11 checks passed
@yamilmedina yamilmedina deleted the feat/logger-with-userid-and-clientid-cherry-pick branch October 17, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants