-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display received location messages - default placeholder (WPB-5483) #2503
Conversation
Build 2159 failed. |
a5e743b
to
a68a6d7
Compare
Build 2176 failed. |
Build 2188 failed. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2503 +/- ##
=============================================
- Coverage 41.31% 41.26% -0.05%
Complexity 1112 1112
=============================================
Files 355 355
Lines 12888 12906 +18
Branches 1684 1687 +3
=============================================
+ Hits 5325 5326 +1
- Misses 7058 7075 +17
Partials 505 505
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2189 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2206 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Currently we are displaying a placeholder that a location was shared "sent a message with Location content"
Causes (Optional)
Not implemented.
Solutions
Display a placeholder for the location message received with the possibility to open the link in google maps.
Dependencies (Optional)
Needs releases with:
feat: queries, storage and mapping for receiving location messages (WPB-5170) kalium#2285
GitHub link to other pull request
Testing
How to Test
Share a location from an iOS device and see it received in android.
Attachments (Optional)
Screen.Recording.2023-12-05.at.10.53.29.mov
Screen.Recording.2023-12-05.at.10.52.57.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.