Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display received location messages - default placeholder (WPB-5483) #2503

Merged
merged 17 commits into from
Dec 8, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 5, 2023

StoryWPB-5483 [Android] Receive Location - UI no image placeholder


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently we are displaying a placeholder that a location was shared "sent a message with Location content"

Causes (Optional)

Not implemented.

Solutions

Display a placeholder for the location message received with the possibility to open the link in google maps.

Dependencies (Optional)

Needs releases with:

Testing

How to Test

Share a location from an iOS device and see it received in android.

Attachments (Optional)

Screen.Recording.2023-12-05.at.10.53.29.mov
Screen.Recording.2023-12-05.at.10.52.57.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@AndroidBob
Copy link
Collaborator

Build 2159 failed.

@yamilmedina yamilmedina force-pushed the feat/display-location-messags branch from a5e743b to a68a6d7 Compare December 6, 2023 15:06
@yamilmedina yamilmedina requested review from alexandreferris, ohassine, a team, borichellow, vitorhugods, Garzas and saleniuk and removed request for a team December 6, 2023 15:07
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Test Results

726 tests   726 ✔️  10m 15s ⏱️
100 suites      0 💤
100 files        0

Results for commit 9e09127.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2176 failed.

@AndroidBob
Copy link
Collaborator

Build 2188 failed.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #2503 (9e09127) into develop (4bb97eb) will decrease coverage by 0.05%.
Report is 2 commits behind head on develop.
The diff coverage is 43.24%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2503      +/-   ##
=============================================
- Coverage      41.31%   41.26%   -0.05%     
  Complexity      1112     1112              
=============================================
  Files            355      355              
  Lines          12888    12906      +18     
  Branches        1684     1687       +3     
=============================================
+ Hits            5325     5326       +1     
- Misses          7058     7075      +17     
  Partials         505      505              
Files Coverage Δ
...ain/kotlin/com/wire/android/notification/Models.kt 0.00% <0.00%> (ø)
...ire/android/feature/ObserveAppLockConfigUseCase.kt 87.50% <80.00%> (+0.40%) ⬆️
...wire/android/mapper/RegularMessageContentMapper.kt 22.66% <0.00%> (-1.28%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 53.21% <0.00%> (-1.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7d4a58...9e09127. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2189 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina requested a review from saleniuk December 8, 2023 11:44
@yamilmedina yamilmedina enabled auto-merge December 8, 2023 12:50
Copy link
Contributor

github-actions bot commented Dec 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2206 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Dec 8, 2023
Merged via the queue into develop with commit d75f286 Dec 8, 2023
14 of 15 checks passed
@yamilmedina yamilmedina deleted the feat/display-location-messags branch December 8, 2023 13:56
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants