-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app not locked after timeout when screen turned off [WPB-5682] [WPB-5832] #2521
fix: app not locked after timeout when screen turned off [WPB-5682] [WPB-5832] #2521
Conversation
@AndroidBob looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2521 +/- ##
=============================================
+ Coverage 41.19% 41.33% +0.14%
- Complexity 1112 1116 +4
=============================================
Files 355 357 +2
Lines 12926 12978 +52
Branches 1690 1698 +8
=============================================
+ Hits 5325 5365 +40
- Misses 7096 7105 +9
- Partials 505 508 +3
Continue to review full report in Codecov by Sentry.
|
@AndroidBob looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2269 succeeded. The build produced the following APK's: |
@AndroidBob looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
APKs built during tests are available here. Scroll down to Artifacts! |
…-when-screen-turned-off-cherry-pick # Conflicts: # kalium
…urned-off-cherry-pick' into fix/app-not-locked-when-screen-turned-off-cherry-pick
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2280 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When the device's screen is being turned off, the app is not locked when the app lock is on.
Causes (Optional)
We use to emit locked state after given timeout, but when the device is turned off, it goes into doze mode and it disrupts the so that it can take way longer than it should:
Solutions
In addition also keep the timestamp and compare it when putting app back into foreground.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Turn app lock on, put the app into background and turn off the screen (phone should not be plugged in and charging), turn it on and open the app after the app lock timeout.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References