Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setting items clickable area [WPB-6225] #2644

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: setting items clickable area [WPB-6225] #2644

merged 3 commits into from
Jan 31, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Jan 31, 2024 •
edited by github-actions bot
Loading

BugWPB-6225 [Android] Enable the entire space of settings entries clickable

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:
kalium

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Settings item's chevron icon prevents clicking on the item, icon takes over the click action and nothing happens then.

Solutions

Make icons not clickable when not needed to be (so that it's not always a button but regular non-clickable icon).

Testing

How to Test

Open settings and try to click on the chevron icon.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

Test Results

754 tests  ±0   754 ✅ ±0   11m 47s ⏱️ - 1m 11s
106 suites ±0     0 💤 ±0 
106 files   ±0     0 ❌ ±0 

Results for commit 985c796. ± Comparison against base commit 90ff364.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, borichellow, vitorhugods, mchenani, ohassine and saleniuk and removed request for a team January 31, 2024 10:58
@AndroidBob
Copy link
Collaborator Author

Build 2805 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina enabled auto-merge January 31, 2024 15:00
@yamilmedina yamilmedina disabled auto-merge January 31, 2024 15:00
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 2818 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Jan 31, 2024
Merged via the queue into develop with commit 122ae8b Jan 31, 2024
14 checks passed
@saleniuk saleniuk deleted the fix/settings-items-clickable-area-cherry-pick branch January 31, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@saleniuk saleniuk

Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndroidBob @yamilmedina @alexandreferris @saleniuk