Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responding to clicks right after navigating [WPB-5468] #2652

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Feb 1, 2024

BugWPB-5468 Join call button not always responds to first click


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Right after navigating, buttons doesn't always respond to the first click, user needs to click again.

Causes (Optional)

It's because of the transition animation - when closing the previous screen it slides it from left to right which means that some portion of the screen is still covered by the previous screen, even if it's not visible because fade out animation is added as well. spring AnimationSpec makes it so that the screen is visible for some time even after navigating so it makes the situation even worse (look at the attachments section - there's a video of this transition without the fade out so that the previous screen is visible for the whole part).

Solutions

Add a visibilityThreshold - thanks to that, the previous screen is removed right as soon as it reaches this threshold and is not left on the screen unnecessarily long after the animation is done.

Testing

How to Test

Navigate and try to click something (preferably on the right side of the screen like "join" call button).

Attachments (Optional)

These videos show the transition animation but without the fade out part of it so that the position of previous screen can be visible for the whole animation and it can be noticed when exactly the previous screen disappears.

Before

before.mp4
After
after.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Test Results

754 tests  ±0   754 ✅ ±0   10m 2s ⏱️ + 2m 43s
106 suites ±0     0 💤 ±0 
106 files   ±0     0 ❌ ±0 

Results for commit 052ffc1. ± Comparison against base commit 122ae8b.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2828 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara and Garzas and removed request for a team February 1, 2024 10:35
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 2, 2024
Merged via the queue into develop with commit c1cf6c2 Feb 2, 2024
14 checks passed
@MohamadJaara MohamadJaara deleted the fix/clicks-right-after-navigating branch February 2, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants