fix: responding to clicks right after navigating [WPB-5468] #2652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Right after navigating, buttons doesn't always respond to the first click, user needs to click again.
Causes (Optional)
It's because of the transition animation - when closing the previous screen it slides it from left to right which means that some portion of the screen is still covered by the previous screen, even if it's not visible because fade out animation is added as well.
spring
AnimationSpec
makes it so that the screen is visible for some time even after navigating so it makes the situation even worse (look at the attachments section - there's a video of this transition without the fade out so that the previous screen is visible for the whole part).Solutions
Add a
visibilityThreshold
- thanks to that, the previous screen is removed right as soon as it reaches this threshold and is not left on the screen unnecessarily long after the animation is done.Testing
How to Test
Navigate and try to click something (preferably on the right side of the screen like "join" call button).
Attachments (Optional)
These videos show the transition animation but without the fade out part of it so that the position of previous screen can be visible for the whole animation and it can be noticed when exactly the previous screen disappears.
Before
before.mp4
After
after.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.