feat: improve permission handling (WPB-6154) #2655

ohassine · 2024-02-01T16:12:06Z

WPB-6154 Improve permissions handling across the app

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We are not handling permission denial properly which makes some features not available.
Affected features:

Attach file/Image
Record Video / Take picture
Change Avatar
Turn camera on for calling
Save backup file

video_1280.mp4

Solutions

Now we check the system to know if a permission is permanently declined. If so, we display a dialog informing the user that he needs to enable that permission from settings to use that feature.

screen-20240201-170935.mp4

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

pull-request-size · 2024-02-01T16:12:17Z

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

github-actions · 2024-02-01T16:15:28Z

Test Results

811 tests - 6 811 ✅ - 6 16m 6s ⏱️ + 2m 21s
114 suites ±0 0 💤 ±0
114 files ±0 0 ❌ ±0

Results for commit 24200e4. ± Comparison against base commit 0be4dc8.

This pull request removes 6 tests.

com.wire.android.ui.calling.incoming.IncomingCallViewModelTest ‑ given default permission dialog state, when calling dismissPermissionDialog, then update the state to false()
com.wire.android.ui.calling.incoming.IncomingCallViewModelTest ‑ given permission dialog default state is false, when calling showPermissionDialog, then update the state to true()
com.wire.android.ui.home.conversations.call.ConversationCallViewModelTest ‑ given default permission dialog state, when calling dismissPermissionDialog, then update the state to false()
com.wire.android.ui.home.conversations.call.ConversationCallViewModelTest ‑ given permission dialog default state is false, when calling showPermissionDialog, then update the state to true()
com.wire.android.ui.home.conversationslist.ConversationListViewModelTest ‑ given default permission dialog state, when calling dismissPermissionDialog, then update the state to false()
com.wire.android.ui.home.conversationslist.ConversationListViewModelTest ‑ given permission dialog default state is false, when calling showPermissionDialog, then update the state to true()

♻️ This comment has been updated with latest results.

AndroidBob · 2024-02-01T16:28:44Z

Build 2836 failed.

…ss_the_app' into improve_permission_handling_across_the_app

github-actions · 2024-02-01T17:07:06Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-02-01T17:24:15Z

Build 2837 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(8783886)(8783886)-staging-compat.apk

app/src/main/kotlin/com/wire/android/ui/calling/SharedCallingViewModel.kt

app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt

…ss_the_app' into improve_permission_handling_across_the_app

github-actions · 2024-02-06T15:08:18Z

APKs built during tests are available here. Scroll down to Artifacts!

github-actions · 2024-02-06T15:59:23Z

APKs built during tests are available here. Scroll down to Artifacts!

github-actions · 2024-02-06T16:31:00Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-02-06T17:24:18Z

Build 2935 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(8827070)(8827070)-staging-compat.apk

…_handling_across_the_app # Conflicts: # kalium

AndroidBob · 2024-02-09T11:09:46Z

Build 3028 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(8850751)(8850751)-staging-compat.apk

…_handling_across_the_app # Conflicts: # kalium

codecov · 2024-02-12T11:27:16Z

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (0be4dc8) 43.04% compared to head (24200e4) 42.92%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2655      +/-   ##
===========================================
- Coverage    43.04%   42.92%   -0.13%     
===========================================
  Files          405      408       +3     
  Lines        13487    13505      +18     
  Branches      2383     2388       +5     
===========================================
- Hits          5806     5797       -9     
- Misses        6998     7025      +27     
  Partials       683      683

Files	Coverage Δ
...e/android/ui/calling/incoming/IncomingCallState.kt	`100.00% <100.00%> (ø)`
...droid/ui/calling/incoming/IncomingCallViewModel.kt	`89.09% <ø> (-0.39%)`	⬇️
...me/conversations/call/ConversationCallViewModel.kt	`61.33% <ø> (-1.01%)`	⬇️
...me/conversations/call/ConversationCallViewState.kt	`100.00% <100.00%> (ø)`
...ome/conversationslist/ConversationListViewModel.kt	`62.89% <ø> (-0.47%)`	⬇️
...id/ui/home/conversationslist/ConversationRouter.kt	`0.00% <ø> (ø)`
...droid/ui/home/messagecomposer/AttachmentOptions.kt	`0.00% <ø> (ø)`
...essagecomposer/location/LocationPickerViewModel.kt	`86.36% <ø> (ø)`
...ome/settings/backup/BackUpAndRestoreStateHolder.kt	`0.00% <ø> (ø)`
...ndroid/ui/userprofile/avatarpicker/AvatarPicker.kt	`0.00% <ø> (ø)`
... and 11 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be4dc8...24200e4. Read the comment docs.

github-actions · 2024-02-12T11:29:40Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-02-12T11:48:37Z

Build 3051 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(8876886)(8876886)-staging-compat.apk

ohassine added 2 commits February 1, 2024 16:55

feat: improve permission handling

6efd843

Merge branch 'develop' into improve_permission_handling_across_the_app

eb919fd

pull-request-size bot added the size/XL label Feb 1, 2024

github-actions bot assigned ohassine Feb 1, 2024

ohassine added 2 commits February 1, 2024 17:31

chore: detekt

d140257

Merge remote-tracking branch 'origin/improve_permission_handling_acro…

6b19663

…ss_the_app' into improve_permission_handling_across_the_app

ohassine requested review from a team, typfel, yamilmedina, vitorhugods, mchenani and saleniuk and removed request for a team February 1, 2024 16:34

saleniuk reviewed Feb 2, 2024

View reviewed changes

app/src/main/kotlin/com/wire/android/ui/calling/SharedCallingViewModel.kt Outdated Show resolved Hide resolved

app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt Outdated Show resolved Hide resolved

ohassine added 2 commits February 6, 2024 15:07

chore: address comment

d53a5dc

Merge branch 'develop' into improve_permission_handling_across_the_app

0acd2ff

ohassine requested a review from saleniuk February 6, 2024 14:08

ohassine added 3 commits February 6, 2024 15:29

chore: update strings

f764d80

Merge remote-tracking branch 'origin/improve_permission_handling_acro…

82dc927

…ss_the_app' into improve_permission_handling_across_the_app

Merge branch 'develop' into improve_permission_handling_across_the_app

af63b2b

Merge branch 'develop' into improve_permission_handling_across_the_app

69802a5

Merge branch 'develop' into improve_permission_handling_across_the_app

6f2f698

yamilmedina approved these changes Feb 7, 2024

View reviewed changes

saleniuk approved these changes Feb 7, 2024

View reviewed changes

ohassine added 4 commits February 9, 2024 10:59

chore: resolve conflicts

d581e52

Merge remote-tracking branch 'origin/develop' into improve_permission…

60761d4

…_handling_across_the_app # Conflicts: # kalium

chore: kalium reference

2a0be5e

Merge remote-tracking branch 'origin/develop' into improve_permission…

5b8a285

…_handling_across_the_app # Conflicts: # kalium

ohassine enabled auto-merge February 9, 2024 10:03

chore: detekt

1133a0e

ohassine added 2 commits February 12, 2024 11:50

chore: kalium reference

8e28835

Merge remote-tracking branch 'origin/develop' into improve_permission…

24200e4

…_handling_across_the_app # Conflicts: # kalium

ohassine added this pull request to the merge queue Feb 12, 2024

Merged via the queue into develop with commit 32085af Feb 12, 2024
15 checks passed

ohassine deleted the improve_permission_handling_across_the_app branch February 12, 2024 12:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve permission handling (WPB-6154) #2655

feat: improve permission handling (WPB-6154) #2655

ohassine commented Feb 1, 2024 •

edited by github-actions bot

Loading

pull-request-size bot commented Feb 1, 2024

github-actions bot commented Feb 1, 2024 •

edited

Loading

AndroidBob commented Feb 1, 2024

github-actions bot commented Feb 1, 2024

AndroidBob commented Feb 1, 2024

github-actions bot commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

AndroidBob commented Feb 6, 2024

AndroidBob commented Feb 9, 2024

codecov bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024

AndroidBob commented Feb 12, 2024

feat: improve permission handling (WPB-6154) #2655

feat: improve permission handling (WPB-6154) #2655

Conversation

ohassine commented Feb 1, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

pull-request-size bot commented Feb 1, 2024

Ups 🫰🟨

github-actions bot commented Feb 1, 2024 • edited Loading

Test Results

AndroidBob commented Feb 1, 2024

github-actions bot commented Feb 1, 2024

AndroidBob commented Feb 1, 2024

github-actions bot commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

AndroidBob commented Feb 6, 2024

AndroidBob commented Feb 9, 2024

codecov bot commented Feb 12, 2024 • edited Loading

Codecov Report

github-actions bot commented Feb 12, 2024

AndroidBob commented Feb 12, 2024

ohassine commented Feb 1, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Feb 1, 2024 •

edited

Loading

codecov bot commented Feb 12, 2024 •

edited

Loading