chore: add git commit hash to external logger #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3274 succeeded. The build produced the following APK's: |
|
Build 3460 failed. |
…hash-to-external-logger-cherry-pick # Conflicts: # kalium
MohamadJaara
approved these changes
Mar 21, 2024
|
@AndroidBob looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
alexandreferris
approved these changes
Mar 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3683 succeeded. The build produced the following APK's: |
…-cherry-pick # Conflicts: # kalium
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3703 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3830 failed. |
yamilmedina
deleted the
chore/add-commit-shash-to-external-logger-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References