Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e webview close [WPB-6788] #2762

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fix: e2e webview close [WPB-6788] #2762

merged 2 commits into from
Mar 4, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 4, 2024 •
edited by github-actions bot
Loading

BugWPB-6788 [Android] Fix crash on opening the browser for E2EI IDP authorization

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

viewModel.getCertificate(isNewClient) was not called from LaunchedEffect, which triggered again on recompose opening webview

Causes (Optional)

E2E webview opened from dialog was closed after second

Solutions

Add LaunchedEffect

@Garzas Garzas self-assigned this Mar 4, 2024
@Garzas Garzas requested review from MohamadJaara and saleniuk March 4, 2024 12:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Test Results

809 tests   809 ✅  8m 8s ⏱️
109 suites    0 💤
109 files      0 ❌

Results for commit af701fb.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

borichellow
borichellow approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delicious, thanks!

@AndroidBob
Copy link
Collaborator

Build 3461 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara enabled auto-merge (squash) March 4, 2024 21:11
@MohamadJaara MohamadJaara merged commit 332bb41 into release/candidate Mar 4, 2024
10 of 11 checks passed
@MohamadJaara MohamadJaara deleted the fix/e2e-webview-close branch March 4, 2024 21:33
@AndroidBob AndroidBob mentioned this pull request Mar 4, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3471 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@borichellow borichellow borichellow approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@Garzas Garzas

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garzas @AndroidBob @borichellow @saleniuk @MohamadJaara