feat: message draft [WPB-1021] #2796

Garzas · 2024-03-17T13:49:48Z

WPB-1021 Keep messages as draft

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Implemented message drafts saved when user types text with mentions and quoted message.

Attachments (Optional)

message_draft.mp4

pull-request-size · 2024-03-17T13:49:54Z

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

codecov · 2024-03-17T14:09:43Z

Codecov Report

Attention: Patch coverage is 32.53589% with 141 lines in your changes are missing coverage. Please review.

Project coverage is 43.66%. Comparing base (50ccd98) to head (87117bf).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2796      +/-   ##
===========================================
+ Coverage    43.57%   43.66%   +0.08%     
===========================================
  Files          414      418       +4     
  Lines        13914    13996      +82     
  Branches      2516     2532      +16     
===========================================
+ Hits          6063     6111      +48     
- Misses        7142     7172      +30     
- Partials       709      713       +4

Files	Coverage Δ
.../ui/home/conversations/MessageComposerViewModel.kt	`83.20% <100.00%> (+0.39%)`	⬆️
...e/android/ui/home/conversations/model/UIMessage.kt	`52.16% <ø> (+2.45%)`	⬆️
...essagecomposer/state/MessageComposerStateHolder.kt	`59.25% <ø> (ø)`
...mposer/state/MessageCompositionInputStateHolder.kt	`67.85% <ø> (ø)`
...versations/messages/draft/MessageDraftViewModel.kt	`96.00% <96.00%> (ø)`
.../messagecomposer/state/MessageCompositionHolder.kt	`45.25% <47.36%> (+12.52%)`	⬆️
...src/main/kotlin/com/wire/android/util/ui/UIText.kt	`42.00% <9.09%> (-8.00%)`	⬇️
...e/android/ui/home/conversations/model/UIMention.kt	`0.00% <0.00%> (ø)`
...oid/ui/home/conversations/model/UIQuotedMessage.kt	`30.30% <30.30%> (ø)`
...s/usecase/GetQuoteMessageForConversationUseCase.kt	`0.00% <0.00%> (ø)`
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ccd98...87117bf. Read the comment docs.

github-actions · 2024-03-17T14:16:43Z

Test Results

879 tests +5 879 ✅ +5 9m 26s ⏱️ - 4m 1s
118 suites +1 0 💤 ±0
118 files +1 0 ❌ ±0

Results for commit 87117bf. ± Comparison against base commit 50ccd98.

This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both.

com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that user sends a text message, when invoked, then send typing stopped event is called()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that user sends an edited text message, when invoked, then send typing stopped event is called()

com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that user saves a draft message, then save draft use case is triggered()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that user sends a text message, when invoked, then send typing stopped event and remove draft are called()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given that user sends an edited text message, when invoked, then send typing stopped event and remove draft are called()
com.wire.android.ui.home.conversations.messages.draft.MessageDraftViewModelTest ‑ given message draft with quoted message, when init, then state is updated()
com.wire.android.ui.home.conversations.messages.draft.MessageDraftViewModelTest ‑ given message draft with unavailable quoted message, when init, then quoted data is not updated()
com.wire.android.ui.home.conversations.messages.draft.MessageDraftViewModelTest ‑ given message draft, when init, then state is properly updated()
com.wire.android.ui.home.conversations.messages.draft.MessageDraftViewModelTest ‑ given null message draft, when init, then state is not updated()

♻️ This comment has been updated with latest results.

github-actions · 2024-03-17T14:16:44Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-17T14:48:50Z

Build 3639 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9171707)(9171707)-staging-compat.apk

alexandreferris

looking great 👌🏻

github-actions · 2024-03-21T11:16:19Z

@Garzas looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
18b7699e312bedf08a441433e25d96fb37dc920f	03bb79416ec85d8deba03349851e338fe600c002

Is this intentional?

github-actions · 2024-03-21T11:19:28Z

@Garzas looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
18b7699e312bedf08a441433e25d96fb37dc920f	03bb79416ec85d8deba03349851e338fe600c002

Is this intentional?

github-actions · 2024-03-21T11:43:37Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-21T12:04:31Z

Build 3673 failed.

AndroidBob · 2024-03-21T12:56:38Z

Build 3677 failed.

github-actions · 2024-03-21T13:52:02Z

@Garzas looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
4be820aa2bb05ffc40a8ec1709660b16cbe6bfdd	91a09ffd30ca372196420b1ef650c71d2e09fdef

Is this intentional?

github-actions · 2024-03-21T14:15:33Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-21T14:47:23Z

Build 3680 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9206275)(9206275)-staging-compat.apk

github-actions · 2024-03-22T09:20:38Z

@Garzas looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
4be820aa2bb05ffc40a8ec1709660b16cbe6bfdd	f9480981c8ec5b1c3004c450449b2e2449335ebe

Is this intentional?

github-actions · 2024-03-22T09:44:44Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-22T10:15:20Z

Build 3686 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9213284)(9213284)-staging-compat.apk

Garzas added 3 commits March 15, 2024 23:08

feat: message draft

ab68914

fix: quote input padding

6b495bc

Merge branch 'develop' into feat/message-draft

aa3fde9

Garzas requested review from yamilmedina, alexandreferris, MohamadJaara, vitorhugods, ohassine and saleniuk March 17, 2024 13:49

Garzas self-assigned this Mar 17, 2024

pull-request-size bot added the size/XL label Mar 17, 2024

saleniuk approved these changes Mar 18, 2024

View reviewed changes

alexandreferris approved these changes Mar 19, 2024

View reviewed changes

Garzas added 3 commits March 21, 2024 12:14

fix: edited message draft

975c09d

kalium update

a913cad

Merge branch 'develop' into feat/message-draft

647db97

detekt fix

4cdfb6b

kalium update

879b126

Garzas added 2 commits March 21, 2024 14:50

kalium update

893c918

Merge branch 'develop' into feat/message-draft

6b0d372

Garzas added this pull request to the merge queue Mar 22, 2024

Garzas removed this pull request from the merge queue due to a manual request Mar 22, 2024

kalium update

87117bf

Garzas added this pull request to the merge queue Mar 22, 2024

Merged via the queue into develop with commit 06d1399 Mar 22, 2024
15 checks passed

Garzas deleted the feat/message-draft branch March 22, 2024 11:02

echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: message draft [WPB-1021] #2796

feat: message draft [WPB-1021] #2796

Garzas commented Mar 17, 2024 •

edited by github-actions bot

Loading

pull-request-size bot commented Mar 17, 2024

codecov bot commented Mar 17, 2024 •

edited

Loading

github-actions bot commented Mar 17, 2024 •

edited

Loading

github-actions bot commented Mar 17, 2024

AndroidBob commented Mar 17, 2024

alexandreferris left a comment

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

AndroidBob commented Mar 21, 2024

AndroidBob commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

AndroidBob commented Mar 21, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

AndroidBob commented Mar 22, 2024

feat: message draft [WPB-1021] #2796

feat: message draft [WPB-1021] #2796

Conversation

Garzas commented Mar 17, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Attachments (Optional)

pull-request-size bot commented Mar 17, 2024

Ups 🫰🟨

codecov bot commented Mar 17, 2024 • edited Loading

Codecov Report

github-actions bot commented Mar 17, 2024 • edited Loading

Test Results

github-actions bot commented Mar 17, 2024

AndroidBob commented Mar 17, 2024

alexandreferris left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

AndroidBob commented Mar 21, 2024

AndroidBob commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

AndroidBob commented Mar 21, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

AndroidBob commented Mar 22, 2024

Garzas commented Mar 17, 2024 •

edited by github-actions bot

Loading

codecov bot commented Mar 17, 2024 •

edited

Loading

github-actions bot commented Mar 17, 2024 •

edited

Loading