feat: update flow for new group conversation creation [WPB-1630] #2797

saleniuk · 2024-03-18T15:46:45Z

WPB-1630 Create new group conversation (new flow)

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updated the flow of creating new conversation according to current designs.
Unified margins for rows that use RowItemTemplate and contain avatars according to current designs.

https://www.figma.com/file/UgKehvwIbiIiQ2CCEdsVuf/Android?node-id=10186%3A103975

Dependencies (Optional)

Needs to be released after:

feat: hide group creation and edit options for external user [WPB-5749] #2794

Testing

How to Test

Try to create new conversation.

Attachments (Optional)

create_conversation_flow_v2.mp4

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…tions-for-external-user

…tions-for-external-user # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/newconversation/NewConversationViewModel.kt # app/src/test/kotlin/com/wire/android/ui/home/newconversation/NewConversationViewModelArrangement.kt

…tions-for-external-user

…rnal-user' into feat/conversation-creation-flow-v2

…tions-for-external-user

…rnal-user' into feat/conversation-creation-flow-v2

github-actions · 2024-03-18T15:50:16Z

Test Results

873 tests +13 873 ✅ +13 16m 38s ⏱️ + 4m 11s
117 suites ± 0 0 💤 ± 0
117 files ± 0 0 ❌ ± 0

Results for commit da127b3. ± Comparison against base commit 2ff2e04.

This pull request removes 7 and adds 20 tests. Note that renamed tests count towards both.

com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user has no teamId and conversation no teamId, when init group options, then read receipt toggle is disabled()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user has no teamId, is admin and conversation has teamId, when init group options, then read receipt toggle is enabled()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user has no teamId, not admin and conversation has teamId, when init group options, then read receipt toggle is enabled()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user has teamId, is admin and conversation teamId, when init group options, then read receipt toggle is enabled()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ when no guests and disable service dialog confirmed, then use case is called with the correct values()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ when no guests and enabling services, use case is called with the correct values()
com.wire.android.ui.home.conversations.search.SearchBarViewModelTest ‑ given addMemberSearchNavArgs is null, then state is updated correctly()

com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and external team member, when init group options, then group name update is not allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and internal team member, when init group options, then group name update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and member of group owner team, when init group options, then guests update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and not member of group owner team, when init group options, then guests update is not allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and not team group, when init group options, then read receipts update is not allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin and team group, when init group options, then read receipts update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin, when init group options, then self deleting update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is admin, when init group options, then services update is allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is not admin and external team member, when init group options, then group name update is not allowed()
com.wire.android.ui.home.conversations.details.GroupConversationDetailsViewModelTest ‑ given user is not admin and internal team member, when init group options, then group name update is not allowed()
…

♻️ This comment has been updated with latest results.

codecov · 2024-03-18T16:20:12Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 43.56%. Comparing base (40e0afb) to head (34bb89a).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2797      +/-   ##
===========================================
- Coverage    43.57%   43.56%   -0.02%     
===========================================
  Files          414      414              
  Lines        13914    13913       -1     
  Branches      2519     2518       -1     
===========================================
- Hits          6063     6061       -2     
- Misses        7144     7145       +1     
  Partials       707      707

Files	Coverage Δ
...ui/home/conversations/search/SearchBarViewModel.kt	`100.00% <ø> (ø)`
...ui/home/conversations/search/SearchPeopleRouter.kt	`0.00% <0.00%> (ø)`
...in/kotlin/com/wire/android/model/ItemActionType.kt	`0.00% <0.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e0afb...34bb89a. Read the comment docs.

github-actions · 2024-03-18T16:28:33Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-18T16:45:58Z

Build 3641 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9181073)(9181073)-staging-compat.apk

…creation-flow-v2 # Conflicts: # app/src/main/kotlin/com/wire/android/model/ItemActionType.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/search/InternalContactSearchResultItem.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/search/SearchPeopleRouter.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/search/adddembertoconversation/AddMembersSearchScreen.kt # app/src/main/kotlin/com/wire/android/ui/home/newconversation/search/NewConversationSearchPeopleScreen.kt # kalium

AndroidBob · 2024-03-18T18:55:49Z

Build 3649 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9181848)(9181848)-staging-compat.apk

alexandreferris

🎉

saleniuk added 15 commits March 15, 2024 12:48

feat: hide group creation and edit options for external user [WPB-5749]

261533d

Merge remote-tracking branch 'origin/develop' into feat/hide-group-op…

a19cd0a

…tions-for-external-user

fix detekt

159f515

update kalium ref

01d9f2b

Merge remote-tracking branch 'origin/develop' into feat/hide-group-op…

81ddf0e

…tions-for-external-user

feat: update flow for new group conversation creation [WPB-1630]

9324040

remove unused import

1911337

Merge remote-tracking branch 'origin/feat/hide-group-options-for-exte…

6f78977

…rnal-user' into feat/conversation-creation-flow-v2

Merge remote-tracking branch 'origin/develop' into feat/hide-group-op…

6b283f2

…tions-for-external-user

fix screenType and back nav icon

3ae2681

remove unused import

f2a78ef

Merge remote-tracking branch 'origin/feat/hide-group-options-for-exte…

18d6f00

…rnal-user' into feat/conversation-creation-flow-v2

update and unify rows with avatars

f84a207

fix modifier

552b96a

saleniuk added the DO NOT MERGE label Mar 18, 2024

pull-request-size bot added the size/L label Mar 18, 2024

github-actions bot assigned saleniuk Mar 18, 2024

fix detekt

da127b3

pull-request-size bot added size/S and removed size/L labels Mar 18, 2024

saleniuk removed the DO NOT MERGE label Mar 18, 2024

update kalium ref

34bb89a

wireapp deleted a comment from github-actions bot Mar 18, 2024

saleniuk requested review from a team, typfel, yamilmedina, mchenani, Garzas and ohassine and removed request for a team March 19, 2024 09:01

alexandreferris approved these changes Mar 19, 2024

View reviewed changes

Garzas approved these changes Mar 22, 2024

View reviewed changes

saleniuk added this pull request to the merge queue Mar 22, 2024

Merged via the queue into develop with commit ec46b08 Mar 22, 2024
13 checks passed

saleniuk deleted the feat/conversation-creation-flow-v2 branch March 22, 2024 10:43

echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update flow for new group conversation creation [WPB-1630] #2797

feat: update flow for new group conversation creation [WPB-1630] #2797

saleniuk commented Mar 18, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 18, 2024 •

edited

Loading

codecov bot commented Mar 18, 2024 •

edited

Loading

github-actions bot commented Mar 18, 2024

AndroidBob commented Mar 18, 2024

AndroidBob commented Mar 18, 2024

alexandreferris left a comment

feat: update flow for new group conversation creation [WPB-1630] #2797

feat: update flow for new group conversation creation [WPB-1630] #2797

Conversation

saleniuk commented Mar 18, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Dependencies (Optional)

Testing

How to Test

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Mar 18, 2024 • edited Loading

Test Results

codecov bot commented Mar 18, 2024 • edited Loading

Codecov Report

github-actions bot commented Mar 18, 2024

AndroidBob commented Mar 18, 2024

AndroidBob commented Mar 18, 2024

alexandreferris left a comment

Choose a reason for hiding this comment

saleniuk commented Mar 18, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 18, 2024 •

edited

Loading

codecov bot commented Mar 18, 2024 •

edited

Loading