-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove notifications on read from another client [WPB-1881] #2802
feat: Remove notifications on read from another client [WPB-1881] #2802
Conversation
Build 3665 failed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2802 +/- ##
===========================================
- Coverage 43.59% 43.57% -0.03%
===========================================
Files 414 414
Lines 13907 13914 +7
Branches 2516 2516
===========================================
Hits 6063 6063
- Misses 7135 7142 +7
Partials 709 709
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment from the Kalium PR
Build 3666 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3669 succeeded. The build produced the following APK's: |
What's new in this PR?
Added handling for new
LocalNotification.ConversationSeen
- removing the corresponding notification.Needs releases with:
Merge after kalium update
wireapp/kalium#2671