Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove notifications on read from another client [WPB-1881] #2802

Merged

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Mar 20, 2024

StoryWPB-1881 Clearing of notifications after messages are read on another client

What's new in this PR?

Added handling for new LocalNotification.ConversationSeen - removing the corresponding notification.

Needs releases with:

Merge after kalium update
wireapp/kalium#2671

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Test Results

874 tests  ±0   874 ✅ ±0   9m 32s ⏱️ - 2m 13s
117 suites ±0     0 💤 ±0 
117 files   ±0     0 ❌ ±0 

Results for commit 0172253. ± Comparison against base commit 01a0da9.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 3665 failed.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 43.57%. Comparing base (01a0da9) to head (0172253).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2802      +/-   ##
===========================================
- Coverage    43.59%   43.57%   -0.03%     
===========================================
  Files          414      414              
  Lines        13907    13914       +7     
  Branches      2516     2516              
===========================================
  Hits          6063     6063              
- Misses        7135     7142       +7     
  Partials       709      709              
Files Coverage Δ
...ain/kotlin/com/wire/android/notification/Models.kt 0.00% <0.00%> (ø)
...android/notification/MessageNotificationManager.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a0da9...0172253. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment from the Kalium PR

@AndroidBob
Copy link
Collaborator

Build 3666 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3669 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit 50ccd98 Mar 21, 2024
15 checks passed
@MohamadJaara MohamadJaara deleted the feat/remove_notifications_on_read_from_another_client branch March 21, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants