-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misleading dialog copy when certificate enrolling fails (WPB-7129) #2805
Merged
MohamadJaara
merged 3 commits into
release/candidate
from
fix/misleading_dialog_copy_when_certificate_enrolling_fails
Mar 22, 2024
Merged
fix: misleading dialog copy when certificate enrolling fails (WPB-7129) #2805
MohamadJaara
merged 3 commits into
release/candidate
from
fix/misleading_dialog_copy_when_certificate_enrolling_fails
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreferris
requested review from
a team,
typfel,
yamilmedina,
borichellow,
MohamadJaara,
saleniuk and
Garzas
and removed request for
a team
March 22, 2024 09:49
saleniuk
approved these changes
Mar 22, 2024
Test Results812 tests 812 ✅ 8m 9s ⏱️ Results for commit 6ad9986. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3691 succeeded. The build produced the following APK's: |
MohamadJaara
requested changes
Mar 22, 2024
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3704 succeeded. The build produced the following APK's: |
MohamadJaara
approved these changes
Mar 22, 2024
MohamadJaara
deleted the
fix/misleading_dialog_copy_when_certificate_enrolling_fails
branch
March 22, 2024 15:39
6 tasks
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When E2EI is already enabled when the user logs in, he is forced to generate his certificate. If this certificate generation fails, we see the wrong copy dialog.
Solutions
Adjust dialog copy with correct information (correct subtext and removal of
Cancel
button)Testing
How to Test
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.