Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misleading dialog copy when certificate enrolling fails (WPB-7129) #2805

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Mar 22, 2024

BugWPB-7129 [Android] Misleading dialogue if certificate generation fails after login with e2ei enabled


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When E2EI is already enabled when the user logs in, he is forced to generate his certificate. If this certificate generation fails, we see the wrong copy dialog.

Solutions

Adjust dialog copy with correct information (correct subtext and removal of Cancel button)

Testing

How to Test

  • have a team with e2ei enabled
  • login on android and tap on “get certificate” button
  • make getting certificate fail (e.g. by providing a wrong acme URL)
  • alert is shown with correct copy

Attachments (Optional)

Before After
old dialog copy new dialog copy

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara, saleniuk and Garzas and removed request for a team March 22, 2024 09:49
Copy link
Contributor

github-actions bot commented Mar 22, 2024

Test Results

812 tests   812 ✅  8m 9s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 6ad9986.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3691 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3704 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit 4dc00e6 into release/candidate Mar 22, 2024
14 checks passed
@MohamadJaara MohamadJaara deleted the fix/misleading_dialog_copy_when_certificate_enrolling_fails branch March 22, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants