Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: legal hold indicator on message headers [WPB-4571] #2806

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Mar 22, 2024

StoryWPB-4571 [Android] Legal hold indication on user name in conversations


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Users who are under legal hold need to have a legal hold indicator next to the user name for every message they send in the conversation 1:1 or group.
This PR basically uses changes from the kalium PR responsible for providing legal hold flag to the user details data.
ObserveLegalHoldStateForUserUseCase is removed from OtherUserProfileScreenViewModel because now this information is already available as part of user details data so no need for additional db query.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Have a 1:1 conversation with other team member and enable legal hold for that member.

Attachments (Optional)

Screen.Recording.2024-03-21.at.14.03.34.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…dicators-on-message-headers

# Conflicts:
#	kalium
Copy link
Contributor

github-actions bot commented Mar 22, 2024

Test Results

873 tests   - 1   873 ✅  - 1   10m 47s ⏱️ + 2m 13s
117 suites ±0     0 💤 ±0 
117 files   ±0     0 ❌ ±0 

Results for commit b087a37. ± Comparison against base commit bb3bc09.

This pull request removes 1 test.
com.wire.android.ui.home.conversations.search.SearchBarViewModelTest ‑ given addMemberSearchNavArgs is null, then state is updated correctly()

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.36%. Comparing base (bb3bc09) to head (b087a37).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2806      +/-   ##
===========================================
- Coverage    43.60%   43.36%   -0.25%     
===========================================
  Files          414      414              
  Lines        13924    13918       -6     
  Branches      2517     2516       -1     
===========================================
- Hits          6072     6035      -37     
- Misses        7142     7180      +38     
+ Partials       710      703       -7     
Files Coverage Δ
...erprofile/other/OtherUserProfileScreenViewModel.kt 58.15% <100.00%> (-0.90%) ⬇️
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 61.22% <0.00%> (-1.03%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb3bc09...b087a37. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3698 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, alexandreferris, vitorhugods, mchenani, Garzas and ohassine and removed request for a team March 22, 2024 14:43
@saleniuk saleniuk added this pull request to the merge queue Mar 25, 2024
Merged via the queue into develop with commit 17f1c2a Mar 25, 2024
15 checks passed
@saleniuk saleniuk deleted the feat/legal-hold-indicators-on-message-headers branch March 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants