-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: legal hold indicator on message headers [WPB-4571] #2806
feat: legal hold indicator on message headers [WPB-4571] #2806
Conversation
…dicators-on-message-headers # Conflicts: # kalium
Test Results873 tests - 1 873 ✅ - 1 10m 47s ⏱️ + 2m 13s Results for commit b087a37. ± Comparison against base commit bb3bc09. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2806 +/- ##
===========================================
- Coverage 43.60% 43.36% -0.25%
===========================================
Files 414 414
Lines 13924 13918 -6
Branches 2517 2516 -1
===========================================
- Hits 6072 6035 -37
- Misses 7142 7180 +38
+ Partials 710 703 -7
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3698 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Users who are under legal hold need to have a legal hold indicator next to the user name for every message they send in the conversation 1:1 or group.
This PR basically uses changes from the kalium PR responsible for providing legal hold flag to the user details data.
ObserveLegalHoldStateForUserUseCase
is removed fromOtherUserProfileScreenViewModel
because now this information is already available as part of user details data so no need for additional db query.Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Have a 1:1 conversation with other team member and enable legal hold for that member.
Attachments (Optional)
Screen.Recording.2024-03-21.at.14.03.34.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.