Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: file access crashes [WPB-7368] #2994

Merged
merged 5 commits into from
May 10, 2024
Merged

chore: file access crashes [WPB-7368] #2994

merged 5 commits into from
May 10, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented May 10, 2024 •
edited by github-actions bot
Loading

BugWPB-7368 [Android] Playstore crash - Resample Image and File handling

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added information about about available space and total device space to datadog
  • added snackbar message when access to file on avatar upload fails
  • added more logs when resampling images
  • code cleanup

@Garzas Garzas self-assigned this May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7c41caa.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 4701 failed.

@Garzas Garzas enabled auto-merge (squash) May 10, 2024 10:00
@Garzas Garzas merged commit ce608e9 into release/candidate May 10, 2024
10 of 11 checks passed
@Garzas Garzas deleted the chore/file-access-crashes branch May 10, 2024 10:15
github-actions bot pushed a commit that referenced this pull request May 10, 2024
@Garzas @github-actions
chore: file access crashes [WPB-7368] (#2994)
56aebba
@github-actions github-actions bot mentioned this pull request May 10, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4703 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

Assignees

@Garzas Garzas

Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @alexandreferris @saleniuk