Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): crash on downloading certificates (WPB-9097) #3000

Merged
merged 3 commits into from
May 14, 2024

Conversation

mchenani
Copy link
Contributor

@mchenani mchenani commented May 14, 2024

BugWPB-9097 [Android] App crashing when viewing own or another users certificate


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adding serialisation annotation to serialisable classes.

Issues

Was missing for android navigation arguments.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani mchenani enabled auto-merge (squash) May 14, 2024 09:16
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding SerialName annotations

@mchenani mchenani requested a review from MohamadJaara May 14, 2024 09:31
@mchenani mchenani merged commit a0fd74f into release/cycle-4.6 May 14, 2024
11 of 12 checks passed
@mchenani mchenani deleted the fix/download-cert branch May 14, 2024 09:54
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4728 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants