fix: Websocket toggle always off [WBP-8669] 🍒 #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
borichellow
approved these changes
May 15, 2024
alexandreferris
approved these changes
May 15, 2024
|
Build 4748 succeeded. The build produced the following APK's: |
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4809 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
In NetworkSetting screen: toggle of Persistent Websocket connection is always off, even when Persistent Connection is on.
Causes (Optional)
The state of toggle is remembered and is not re-composed after state changing.
Solutions
Fix it