fix: jumping keyboard behavior (WPB-9357) #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
requested review from
Garzas,
a team,
alexandreferris,
vitorhugods,
mchenani and
ohassine
and removed request for
a team
yamilmedina
commented
May 22, 2024
| @@ -301,11 +301,11 @@ fun EnabledMessageComposer( | |||
| if (additionalOptionStateHolder.selectedOption == AdditionalOptionSelectItem.DrawingMode) { | |||
| DrawingCanvasBottomSheet( | |||
| onDismissSketch = { | |||
| inputStateHolder.collapseComposer(additionalOptionStateHolder.additionalOptionsSubMenuState) | |||
| showAdditionalOptionsMenu() | |||
There was a problem hiding this comment.
Just delegate all the orchestration to the function, instead of manually collapsing just the keyboard
Test Results927 tests 927 ✅ 12m 8s ⏱️ Results for commit cd9416a. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4874 succeeded. The build produced the following APK's: |
Garzas
approved these changes
May 22, 2024
MohamadJaara
approved these changes
May 22, 2024
borichellow
approved these changes
May 22, 2024
saleniuk
approved these changes
May 22, 2024
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4896 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When opening the sketch and discarding the drawing, sometimes, the keyboard behavior while closing had an anomaly.
Causes (Optional)
Jumping keyboard effect.
Solutions
Instead of collapsing manually the keyboard, jump back to the attachment options, this handles and orchestrate other actions needed, to display correctly the attachments.
Testing
Test Coverage (Optional)
How to Test
Manually you can have many messages, open the drawing, draw, discard.
Then the keyboard should close correctly
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.