Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OtherUser devices: wrong MLS data [WPB-8908] #3040

Merged
merged 6 commits into from
Jun 5, 2024
Merged

fix: OtherUser devices: wrong MLS data [WPB-8908] #3040

merged 6 commits into from
Jun 5, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented May 27, 2024 •
edited by github-actions bot
Loading

BugWPB-8908 [Android] MLS Client data not loaded correctly for other users devices

What's new in this PR?

Issues

In OtherUserProfile screen: MLS data in devices is wrong (no MLS thumbprint)
The same in DeviceDetails screen

Causes (Optional)

MLS thumbprint should be gotten from the com.wire.kalium.logic.feature.e2ei.E2eiCertificate not com.wire.kalium.logic.data.client.Client.

Solutions

Use the proper source of trues.

Attachments (Optional)

Screenshot 2024-05-27 at 15 18 04 Screenshot 2024-05-27 at 15 18 15

@borichellow borichellow self-assigned this May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 27, 2024 •
edited
Loading

Test Results

824 tests   824 ✅  9m 25s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 601c95e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5005 succeeded.

The build produced the following APK's:

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5013 succeeded.

The build produced the following APK's:

yamilmedina
yamilmedina reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just would be nice to cover this with tests

app/src/main/kotlin/com/wire/android/ui/settings/devices/DeviceDetailsViewModel.kt Show resolved Hide resolved
@borichellow borichellow requested a review from yamilmedina May 28, 2024 14:09
@AndroidBob
Copy link
Collaborator

Build 5055 failed.

yamilmedina
yamilmedina approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AndroidBob
Copy link
Collaborator

Build 5061 failed.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5062 succeeded.

The build produced the following APK's:

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5150 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods merged commit 4aeb39d into release/cycle-4.6 Jun 5, 2024
13 checks passed
@vitorhugods vitorhugods deleted the fix/other_user_devices_wrong_mls_data branch June 5, 2024 08:18
This was referenced Jun 5, 2024
Merged
Merged
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@mchenani mchenani Awaiting requested review from mchenani

@Garzas Garzas Awaiting requested review from Garzas

@ohassine ohassine Awaiting requested review from ohassine

Assignees

@borichellow borichellow

Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@borichellow @AndroidBob @yamilmedina @saleniuk @vitorhugods