Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proximity sensor keeps turning the screen off even when there is no call (WPB-9215) 🍒 #3052

Merged
merged 2 commits into from
May 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 29, 2024

BugWPB-9215 [Android] Screen dimming is on even when there are no active calls

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Proximity sensor keeps turning the screen off even when there is no call

Causes (Optional)

We are not releasing wakeLock when unregistering the sensor listener

Solutions

Release wakeLock if it's held when unregistering the listener

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

STR:

  • Receive an incoming call
  • Turn off the screen by hiding the sensor
  • The caller should end the call
    --> the phone will keep dimming the screen even the app is not open

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels May 29, 2024
@ohassine ohassine requested review from a team, yamilmedina, borichellow, mchenani, ohassine and saleniuk and removed request for a team May 29, 2024 09:17
@ohassine ohassine enabled auto-merge May 29, 2024 09:53
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ohassine ohassine added this pull request to the merge queue May 29, 2024
@AndroidBob
Copy link
Collaborator

Build 5066 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit d6cdb11 May 29, 2024
11 checks passed
@ohassine ohassine deleted the proximity-sensor-keeps-working-cherry-pick branch May 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants