Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fdroid unresolved reference in rememberTrackingAnimatedNavController WPB-7288 #3073

Closed
wants to merge 2 commits into from

Conversation

e-lisa
Copy link
Contributor

@e-lisa e-lisa commented Jun 4, 2024

…riants


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@e-lisa e-lisa marked this pull request as draft June 4, 2024 09:33
@e-lisa e-lisa changed the title DRAFT fix: fdroid unresolved reference in rememberTrackingAnimatedNavController WPB-7288 fix: fdroid unresolved reference in rememberTrackingAnimatedNavController WPB-7288 Jun 4, 2024
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vitorhugods
Copy link
Member

Hi hi hi @e-lisa. Could you please also take a look into this PR:

I aimed to get better IDE support when developing F-Droid and make it more cache-friendly by making sure configuration won't change between called tasks.

@e-lisa
Copy link
Contributor Author

e-lisa commented Jun 7, 2024

Hi hi hi @e-lisa. Could you please also take a look into this PR:

* [chore: solve foss source sets and dependencies statically #3082](https://github.com/wireapp/wire-android/pull/3082)

I aimed to get better IDE support when developing F-Droid and make it more cache-friendly by making sure configuration won't change between called tasks.

Looks to accomplish the same goal, going to close this MR. Will test to see if the Jira ticket is still valid after #3082

@e-lisa e-lisa closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants