Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camera on/off button when in fullscreen [WPB-9815] 🍒 #3122

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 24, 2024

BugWPB-9815 [Android] app continues to stream video even if video is turned off

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When a user double taps to expand (open in fullscreen) any participant's video, the button to toggle camera is not doing anything so if the user has camera enabled, then opens fullscreen and clicks on a camera button to turn it off, the button indicates that the camera is now off for the user but the app continues streaming video to other participants.

Causes (Optional)

Calls to start or stop sending video feed were associated with setting or clearing self video preview but only for the participants grid, not the fullscreen mode.

Solutions

Make start or stop sending video actions to be associated with isCameraOn state changes, independently from setting or clearing the video preview view - the user may not have the preview view present (because other participant's video is expanded to fullscreen) but still stream the video and be able to change camera state by clicking on a button.

Testing

How to Test

  • Start a video call.
  • Turn on your camera.
  • Double tap on your video to expand it.
  • Turn off your camera.

Expected Result: The camera should turn off for both the user and other participants, stopping the video stream.
Actual Result: For the user, the video appears to be off, but other participants can still see the video stream.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from saleniuk, a team, yamilmedina, alexandreferris, borichellow and ohassine and removed request for saleniuk and a team June 24, 2024 15:49
Copy link

Copy link
Contributor Author

Test Results

930 tests   930 ✅  12m 58s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit aed9b55.

Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk merged commit 03a908e into release/candidate Jun 24, 2024
13 checks passed
@saleniuk saleniuk deleted the fix/camera-on-off-button-in-fullscreen-cherry-pick branch June 24, 2024 16:48
github-actions bot added a commit that referenced this pull request Jun 24, 2024
Co-authored-by: Michał Saleniuk <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants