Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camera on/off button when in fullscreen - 🍒 v4.5 [WPB-9815] #3128

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jun 25, 2024

BugWPB-9815 [Android] app continues to stream video even if video is turned off


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This is a combined cherry-pick PR consisting of these two PRs:

The main gole is to fix camera on/off button when in fullscreen, but in order to do that, also this first PR needs to be merged as it contains valid changes as well. Also, changes in kalium required to provide new use case.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Start a video call.
  • Turn on your camera.
  • Double tap on your video to expand it.
  • Turn off your camera.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, vitorhugods, mchenani and Garzas and removed request for a team June 25, 2024 12:01
Copy link
Contributor

github-actions bot commented Jun 25, 2024

Test Results

703 tests   703 ✅  10m 39s ⏱️
 99 suites    0 💤
 99 files      0 ❌

Results for commit 680424d.

♻️ This comment has been updated with latest results.

@saleniuk saleniuk added the cherry-pick PR is cherry-picking changes from another banch label Jun 25, 2024
Copy link

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk merged commit d37d51b into release/cycle-4.5 Jun 25, 2024
13 checks passed
@saleniuk saleniuk deleted the fix/camera-on-off-button-in-fullscreen-cherry-pick-4.5 branch June 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants