Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio converting time - rc 4.7 [WPB-9705] #3132

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jun 26, 2024

BugWPB-9705 [Android] App freezes and delays when sending voice messages


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry pick from fix for develop #3127

Issues

Converting audio file to m4a takes too long

Causes (Optional)

Bad user experience waiting for audio to be encoded

Solutions

  • change audio encoding to wav
  • introduce encoding state to be showed when user recorded long audio file

How to Test

  1. Record long audio file (about 3mins)
  2. After stop it should show Audio encoding message for few seconds
  3. Send audio message

Copy link

Copy link
Contributor

Test Results

930 tests   930 ✅  11m 38s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit ec19b94.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina changed the title fix: audio converting time [WPB-9705] fix: audio converting time - rc 4.7 [WPB-9705] Jun 26, 2024
@yamilmedina yamilmedina enabled auto-merge (squash) June 27, 2024 06:22
@yamilmedina yamilmedina merged commit 377cf85 into release/candidate Jun 27, 2024
16 checks passed
@yamilmedina yamilmedina deleted the fix/rc-audio-converting-time branch June 27, 2024 07:21
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants