Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when loading what's new section [WPB-9810] 🍒 #3134

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 27, 2024

BugWPB-9810 [Android] Crash when pressing on the what's new section

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On Bund build Column 3, The Android app crashes when the user presses on the "What's New" section in version 4.6.3.

Causes (Optional)

Probably because url_rss_release_notes is not present in bund build config.

Solutions

Move this url to string resources so that it's always available, all builds have the same release notes for its versions.
Add loading state for the "what's new" screen.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Open drawer menu and select "what's new".

Attachments (Optional)

Screen_recording_20240626_144635.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, yamilmedina, borichellow, MohamadJaara, Garzas and saleniuk and removed request for a team June 27, 2024 10:13
Copy link

Copy link
Contributor Author

Test Results

932 tests   932 ✅  9m 36s ⏱️
124 suites    0 💤
124 files      0 ❌

Results for commit a39948e.

Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk merged commit bac2e63 into release/candidate Jun 27, 2024
13 checks passed
@saleniuk saleniuk deleted the fix/whats-new-crash-cherry-pick branch June 27, 2024 11:40
github-actions bot added a commit that referenced this pull request Jun 27, 2024
Co-authored-by: Michał Saleniuk <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants