fix: handle NoCommonProtocol error while starting conversation cherry-pick #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Garzas
approved these changes
Jun 27, 2024
yamilmedina
approved these changes
Jun 27, 2024
Test Results932 tests 932 ✅ 8m 55s ⏱️ Results for commit b9344f5. |
|
I see it failed with |
borichellow
deleted the
fix/handle-no-common-protocol-error-while-starting-conversation-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason auto-cherry-pick didn't work, so i raised it by myself
cherry-pick of #3120
What's new in this PR?
Issues
When user is trying to start 1o1 conversation with user that has no common protocol with, the error is no displayed anyhow.
Causes (Optional)
Error handling in creating conversation was implemented only for NoKeypackages error.
Solutions
Add handling for all errors (specific texts for
NoKeypackagesandNoCommonProtocolerrors and some default text for other errors.)Attachments (Optional)